@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update a handful of missed HarbormasterBuildableStatus constants
Summary: See <https://discourse.phabricator-community.org/t/exception-undefined-class-status-building/1103>.
Test Plan: Used `grep` more carefully.
Differential Revision: https://secure.phabricator.com/D19068
+5
-5
+5
-5
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+5
-5
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
1236
1236
}
1237
1237
case PhabricatorTransactions::TYPE_BUILDABLE:
1238
1238
switch ($this->getNewValue()) {
1239
-
case HarbormasterBuildable::STATUS_BUILDING:
1239
+
case HarbormasterBuildableStatus::STATUS_BUILDING:
1240
1240
return pht(
1241
1241
'%s started building %s for %s.',
1242
1242
$this->renderHandleLink($author_phid),
1243
1243
$this->renderHandleLink(
1244
1244
$this->getMetadataValue('harbormaster:buildablePHID')),
1245
1245
$this->renderHandleLink($object_phid));
1246
-
case HarbormasterBuildable::STATUS_PASSED:
1246
+
case HarbormasterBuildableStatus::STATUS_PASSED:
1247
1247
return pht(
1248
1248
'%s completed building %s for %s.',
1249
1249
$this->renderHandleLink($author_phid),
1250
1250
$this->renderHandleLink(
1251
1251
$this->getMetadataValue('harbormaster:buildablePHID')),
1252
1252
$this->renderHandleLink($object_phid));
1253
-
case HarbormasterBuildable::STATUS_FAILED:
1253
+
case HarbormasterBuildableStatus::STATUS_FAILED:
1254
1254
return pht(
1255
1255
'%s failed to build %s for %s.',
1256
1256
$this->renderHandleLink($author_phid),
···
1418
1418
return pht('Changed Subscribers');
1419
1419
case PhabricatorTransactions::TYPE_BUILDABLE:
1420
1420
switch ($this->getNewValue()) {
1421
-
case HarbormasterBuildable::STATUS_PASSED:
1421
+
case HarbormasterBuildableStatus::STATUS_PASSED:
1422
1422
return pht('Build Passed');
1423
-
case HarbormasterBuildable::STATUS_FAILED:
1423
+
case HarbormasterBuildableStatus::STATUS_FAILED:
1424
1424
return pht('Build Failed');
1425
1425
default:
1426
1426
return pht('Build Status');