@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Simplify "Blame Revision" field in Differential
Summary: Ref T11114. This is still mostly in use, but toss a few commit message parsing things.
Test Plan: Viewed/edited/upated blame rev from CLI/web UI.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11114
Differential Revision: https://secure.phabricator.com/D17089
+4
-19
+4
-19
src/applications/differential/customfield/DifferentialBlameRevisionField.php
+4
-19
src/applications/differential/customfield/DifferentialBlameRevisionField.php
···
32
32
}
33
33
34
34
public function renderPropertyViewValue(array $handles) {
35
+
if (!strlen($this->getValue())) {
36
+
return null;
37
+
}
38
+
35
39
return $this->getValue();
36
40
}
37
41
···
89
93
90
94
public function shouldAppearInCommitMessage() {
91
95
return true;
92
-
}
93
-
94
-
public function shouldAllowEditInCommitMessage() {
95
-
return true;
96
-
}
97
-
98
-
public function shouldOverwriteWhenCommitMessageIsEdited() {
99
-
return true;
100
-
}
101
-
102
-
public function getCommitMessageLabels() {
103
-
return array(
104
-
'Blame Revision',
105
-
'Blame Rev',
106
-
);
107
-
}
108
-
109
-
public function renderCommitMessageValue(array $handles) {
110
-
return $this->getValue();
111
96
}
112
97
113
98
public function shouldAppearInConduitDictionary() {