recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use modern revision statuses when bucketing revisions on the Differential dashboard

Summary: Ref T2543. Swaps these over to modern constants.

Test Plan: Viewed dashboard, no chagnes to bucketing.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18414

epriestley 895f0cde 7f743c14

+11 -9
+7 -9
src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php
··· 151 151 152 152 private function filterShouldUpdate(array $phids) { 153 153 $statuses = array( 154 - ArcanistDifferentialRevisionStatus::NEEDS_REVISION, 155 - ArcanistDifferentialRevisionStatus::CHANGES_PLANNED, 156 - ArcanistDifferentialRevisionStatus::IN_PREPARATION, 154 + DifferentialRevisionStatus::NEEDS_REVISION, 155 + DifferentialRevisionStatus::CHANGES_PLANNED, 157 156 ); 158 157 $statuses = array_fuse($statuses); 159 158 ··· 161 160 162 161 $results = array(); 163 162 foreach ($objects as $key => $object) { 164 - if (empty($statuses[$object->getStatus()])) { 163 + if (empty($statuses[$object->getModernRevisionStatus()])) { 165 164 continue; 166 165 } 167 166 ··· 190 189 191 190 private function filterWaitingOnAuthors(array $phids) { 192 191 $statuses = array( 193 - ArcanistDifferentialRevisionStatus::ACCEPTED, 194 - ArcanistDifferentialRevisionStatus::NEEDS_REVISION, 195 - ArcanistDifferentialRevisionStatus::CHANGES_PLANNED, 196 - ArcanistDifferentialRevisionStatus::IN_PREPARATION, 192 + DifferentialRevisionStatus::ACCEPTED, 193 + DifferentialRevisionStatus::NEEDS_REVISION, 194 + DifferentialRevisionStatus::CHANGES_PLANNED, 197 195 ); 198 196 $statuses = array_fuse($statuses); 199 197 ··· 201 199 202 200 $results = array(); 203 201 foreach ($objects as $key => $object) { 204 - if (empty($statuses[$object->getStatus()])) { 202 + if (empty($statuses[$object->getModernRevisionStatus()])) { 205 203 continue; 206 204 } 207 205
+4
src/applications/differential/storage/DifferentialRevision.php
··· 627 627 return $this->setStatus($legacy_status); 628 628 } 629 629 630 + public function getModernRevisionStatus() { 631 + return $this->getStatusObject()->getKey(); 632 + } 633 + 630 634 public function isClosed() { 631 635 return $this->getStatusObject()->isClosedStatus(); 632 636 }