@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

a11y: Set aria-label attribute for Edit button on workboard card

Summary:
Links should have a discernible name per https://dequeuniversity.com/rules/axe/4.10/link-name
The "Edit" buttons (created by creating `id(new PHUIListItemView())` in `ProjectBoardTaskCard`) for each task card on a project workboard currently do not have any description what they actually do (they have a tooltip already but that is not recognized by screenreader software).

This is quite similar to rP60c0ed86.

Refs T16072

Test Plan:
* While logged in, go to http://phorge.localhost/project/board/1/
* Hover over a task card in a column to see the Edit button in the upper right corner. It now has a descriptive `aria-label="Edit Task"` attribute.
* Optionally, run an Accessibility check in Chromium Lighthouse.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16072

Differential Revision: https://we.phorge.it/D26223

+1
+1
src/applications/project/view/ProjectBoardTaskCard.php
··· 117 117 ->setName(pht('Edit')) 118 118 ->setIcon($edit_icon) 119 119 ->addSigil('edit-project-card') 120 + ->setAriaLabel(pht('Edit Task')) 120 121 ->setHref('/maniphest/task/edit/'.$task->getID().'/')); 121 122 } 122 123