@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Misc Diffusion/Differential CSS tweaks
Summary: Various tweaks and fixes. Adds a File Contents view in Diffusion, normalizes spaces, colors.
Test Plan: tested differential and diffusion in my sandbox.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Maniphest Tasks: T3952
Differential Revision: https://secure.phabricator.com/D7325
+58
-65
+23
-23
src/__celerity_resource_map__.php
+23
-23
src/__celerity_resource_map__.php
···
1031
1031
),
1032
1032
'differential-changeset-view-css' =>
1033
1033
array(
1034
-
'uri' => '/res/f8fc5deb/rsrc/css/application/differential/changeset-view.css',
1034
+
'uri' => '/res/0e780c41/rsrc/css/application/differential/changeset-view.css',
1035
1035
'type' => 'css',
1036
1036
'requires' =>
1037
1037
array(
···
1109
1109
),
1110
1110
'differential-revision-history-css' =>
1111
1111
array(
1112
-
'uri' => '/res/bb29e0e8/rsrc/css/application/differential/revision-history.css',
1112
+
'uri' => '/res/13b4c17b/rsrc/css/application/differential/revision-history.css',
1113
1113
'type' => 'css',
1114
1114
'requires' =>
1115
1115
array(
···
1136
1136
),
1137
1137
'diffusion-commit-view-css' =>
1138
1138
array(
1139
-
'uri' => '/res/b445944e/rsrc/css/application/diffusion/commit-view.css',
1139
+
'uri' => '/res/a48ea65a/rsrc/css/application/diffusion/commit-view.css',
1140
1140
'type' => 'css',
1141
1141
'requires' =>
1142
1142
array(
···
1154
1154
),
1155
1155
'diffusion-source-css' =>
1156
1156
array(
1157
-
'uri' => '/res/072800bb/rsrc/css/application/diffusion/diffusion-source.css',
1157
+
'uri' => '/res/f4a2f867/rsrc/css/application/diffusion/diffusion-source.css',
1158
1158
'type' => 'css',
1159
1159
'requires' =>
1160
1160
array(
···
4383
4383
'uri' => '/res/pkg/4ccfeb47/darkconsole.pkg.js',
4384
4384
'type' => 'js',
4385
4385
),
4386
-
'f5d1e7d3' =>
4386
+
'7cd7e387' =>
4387
4387
array(
4388
4388
'name' => 'differential.pkg.css',
4389
4389
'symbols' =>
···
4402
4402
11 => 'differential-local-commits-view-css',
4403
4403
12 => 'inline-comment-summary-css',
4404
4404
),
4405
-
'uri' => '/res/pkg/f5d1e7d3/differential.pkg.css',
4405
+
'uri' => '/res/pkg/7cd7e387/differential.pkg.css',
4406
4406
'type' => 'css',
4407
4407
),
4408
4408
'5e9e5c4e' =>
···
4433
4433
'uri' => '/res/pkg/5e9e5c4e/differential.pkg.js',
4434
4434
'type' => 'js',
4435
4435
),
4436
-
'c8ce2d88' =>
4436
+
'270f4eb4' =>
4437
4437
array(
4438
4438
'name' => 'diffusion.pkg.css',
4439
4439
'symbols' =>
···
4441
4441
0 => 'diffusion-commit-view-css',
4442
4442
1 => 'diffusion-icons-css',
4443
4443
),
4444
-
'uri' => '/res/pkg/c8ce2d88/diffusion.pkg.css',
4444
+
'uri' => '/res/pkg/270f4eb4/diffusion.pkg.css',
4445
4445
'type' => 'css',
4446
4446
),
4447
4447
96909266 =>
···
4522
4522
'aphront-tokenizer-control-css' => 'a4e76ef8',
4523
4523
'aphront-tooltip-css' => 'a4e76ef8',
4524
4524
'aphront-typeahead-control-css' => 'a4e76ef8',
4525
-
'differential-changeset-view-css' => 'f5d1e7d3',
4526
-
'differential-core-view-css' => 'f5d1e7d3',
4525
+
'differential-changeset-view-css' => '7cd7e387',
4526
+
'differential-core-view-css' => '7cd7e387',
4527
4527
'differential-inline-comment-editor' => '5e9e5c4e',
4528
-
'differential-local-commits-view-css' => 'f5d1e7d3',
4529
-
'differential-results-table-css' => 'f5d1e7d3',
4530
-
'differential-revision-add-comment-css' => 'f5d1e7d3',
4531
-
'differential-revision-comment-css' => 'f5d1e7d3',
4532
-
'differential-revision-comment-list-css' => 'f5d1e7d3',
4533
-
'differential-revision-history-css' => 'f5d1e7d3',
4534
-
'differential-revision-list-css' => 'f5d1e7d3',
4535
-
'differential-table-of-contents-css' => 'f5d1e7d3',
4536
-
'diffusion-commit-view-css' => 'c8ce2d88',
4537
-
'diffusion-icons-css' => 'c8ce2d88',
4528
+
'differential-local-commits-view-css' => '7cd7e387',
4529
+
'differential-results-table-css' => '7cd7e387',
4530
+
'differential-revision-add-comment-css' => '7cd7e387',
4531
+
'differential-revision-comment-css' => '7cd7e387',
4532
+
'differential-revision-comment-list-css' => '7cd7e387',
4533
+
'differential-revision-history-css' => '7cd7e387',
4534
+
'differential-revision-list-css' => '7cd7e387',
4535
+
'differential-table-of-contents-css' => '7cd7e387',
4536
+
'diffusion-commit-view-css' => '270f4eb4',
4537
+
'diffusion-icons-css' => '270f4eb4',
4538
4538
'global-drag-and-drop-css' => 'a4e76ef8',
4539
-
'inline-comment-summary-css' => 'f5d1e7d3',
4539
+
'inline-comment-summary-css' => '7cd7e387',
4540
4540
'javelin-aphlict' => 'adee86d9',
4541
4541
'javelin-behavior' => '3e3be199',
4542
4542
'javelin-behavior-aphlict-dropdown' => 'adee86d9',
···
4615
4615
'phabricator-action-list-view-css' => 'a4e76ef8',
4616
4616
'phabricator-application-launch-view-css' => 'a4e76ef8',
4617
4617
'phabricator-busy' => 'adee86d9',
4618
-
'phabricator-content-source-view-css' => 'f5d1e7d3',
4618
+
'phabricator-content-source-view-css' => '7cd7e387',
4619
4619
'phabricator-core-css' => 'a4e76ef8',
4620
4620
'phabricator-crumbs-view-css' => 'a4e76ef8',
4621
4621
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
···
4633
4633
'phabricator-notification' => 'adee86d9',
4634
4634
'phabricator-notification-css' => 'a4e76ef8',
4635
4635
'phabricator-notification-menu-css' => 'a4e76ef8',
4636
-
'phabricator-object-selector-css' => 'f5d1e7d3',
4636
+
'phabricator-object-selector-css' => '7cd7e387',
4637
4637
'phabricator-phtize' => 'adee86d9',
4638
4638
'phabricator-prefab' => 'adee86d9',
4639
4639
'phabricator-project-tag-css' => '49898640',
+4
-1
src/applications/diffusion/controller/DiffusionBrowseFileController.php
+4
-1
src/applications/diffusion/controller/DiffusionBrowseFileController.php
···
297
297
$corpus = phutil_tag(
298
298
'div',
299
299
array(
300
-
'style' => 'padding: 0 2em;',
301
300
'id' => $id,
302
301
),
303
302
$corpus_table);
303
+
304
+
$corpus = id(new PHUIObjectBoxView())
305
+
->setHeaderText('File Contents')
306
+
->appendChild($corpus);
304
307
305
308
Javelin::initBehavior('load-blame', array('id' => $id));
306
309
}
+7
-3
src/applications/diffusion/controller/DiffusionCommitController.php
+7
-3
src/applications/diffusion/controller/DiffusionCommitController.php
···
129
129
$message = $engine->markupText($message);
130
130
131
131
$property_list->invokeWillRenderEvent();
132
-
$property_list->addTextContent(
132
+
$property_list->setActionList($headsup_actions);
133
+
134
+
$detail_list = new PHUIPropertyListView();
135
+
$detail_list->addSectionHeader(pht('Description'));
136
+
$detail_list->addTextContent(
133
137
phutil_tag(
134
138
'div',
135
139
array(
···
137
141
),
138
142
$message));
139
143
$content[] = $top_anchor;
140
-
$property_list->setActionList($headsup_actions);
141
144
142
145
$object_box = id(new PHUIObjectBoxView())
143
146
->setHeader($headsup_view)
144
-
->addPropertyList($property_list);
147
+
->addPropertyList($property_list)
148
+
->addPropertyList($detail_list);
145
149
146
150
$content[] = $object_box;
147
151
}
+4
-5
webroot/rsrc/css/application/differential/changeset-view.css
+4
-5
webroot/rsrc/css/application/differential/changeset-view.css
···
5
5
.differential-changeset {
6
6
position: relative;
7
7
margin: 0;
8
-
padding: 16px 0;
8
+
padding-top: 32px;
9
9
}
10
10
11
11
.differential-diff {
···
268
268
}
269
269
270
270
.differential-inline-comment-synthetic .differential-inline-comment-head {
271
-
border-bottom: 1px solid {$thinblueborder};
271
+
border-bottom: 1px solid {$blueborder};
272
272
}
273
273
274
274
···
303
303
304
304
.differential-property-table {
305
305
width: auto;
306
-
margin: .75em auto;
306
+
margin: 12px auto;
307
307
background: #e3e3e3;
308
308
}
309
309
···
367
367
}
368
368
369
369
.differential-inline-comment-edit-buttons {
370
-
padding: 5px 0 0 0;
371
-
370
+
padding: 4px 0 0 0;
372
371
}
373
372
374
373
.differential-inline-comment-edit-buttons button {
+8
-15
webroot/rsrc/css/application/differential/revision-history.css
+8
-15
webroot/rsrc/css/application/differential/revision-history.css
···
8
8
border-spacing: 1px;
9
9
}
10
10
11
-
.differential-revision-history-table th {
12
-
color: {$greytext};
13
-
padding: 4px 6px;
14
-
}
15
-
11
+
.differential-revision-history-table th,
16
12
.differential-revision-history-table td {
17
-
padding: 4px 6px;
13
+
color: {$darkbluetext};
14
+
padding: 4px 8px;
18
15
}
19
16
20
17
.differential-revision-history-table td {
···
22
19
}
23
20
24
21
.differential-revision-history-table tr.alt {
25
-
background: #dcdcdc;
22
+
background: {$greybackground};
26
23
}
27
-
28
24
29
25
.differential-revision-history-table td.revhistory-desc {
30
26
width: 100%;
···
41
37
42
38
.differential-revision-history-table td.revhistory-old,
43
39
.differential-revision-history-table td.revhistory-new {
44
-
padding: 0em 1.5em;
40
+
padding: 0 16px;
45
41
text-align: center;
46
42
}
47
43
···
65
61
text-align: center;
66
62
}
67
63
68
-
69
-
70
-
71
64
.differential-revision-history-table td.diff-differ-submit {
72
65
text-align: right;
73
66
border-bottom: none;
74
-
padding: 8px 0px 4px 0px;
67
+
padding: 8px 0 4px 0;
75
68
}
76
69
77
70
.differential-revision-history-table td.diff-differ-submit button {
78
-
margin-left: 1em;
71
+
margin-left: 12px;
79
72
}
80
73
81
74
.differential-revision-history-table td.diff-differ-submit label {
82
75
font-weight: bold;
83
-
padding-right: .25em;
76
+
padding-right: 4px;
84
77
color: {$darkgreytext};
85
78
}
-4
webroot/rsrc/css/application/diffusion/commit-view.css
-4
webroot/rsrc/css/application/diffusion/commit-view.css
+12
-14
webroot/rsrc/css/application/diffusion/diffusion-source.css
+12
-14
webroot/rsrc/css/application/diffusion/diffusion-source.css
···
3
3
*/
4
4
5
5
.diffusion-source {
6
-
margin: 1em 0 2em;
7
6
width: 100%;
8
7
font-family: "Monaco", Consolas, monospace;
9
8
font-size: 10px;
···
15
14
}
16
15
17
16
.diffusion-source th {
18
-
text-align: right;
19
-
vertical-align: top;
20
-
background: #eeeeee;
21
-
color: {$lightgreytext};
22
-
border-style: solid;
23
-
border-width: 0px 1px;
24
-
border-color: #eeeeee #999999 #eeeeee #dddddd;
25
-
font-size: 11px;
17
+
text-align: right;
18
+
vertical-align: top;
19
+
background: {$lightgreybackground};
20
+
color: {$bluetext};
21
+
border-right: 1px solid {$thinblueborder};
22
+
font-size: 11px;
26
23
}
27
24
28
25
.diffusion-source td {
···
46
43
}
47
44
48
45
.diffusion-blame-link {
49
-
min-width: 25px;
46
+
min-width: 28px;
50
47
}
51
48
52
49
.diffusion-rev-link {
···
61
58
.diffusion-rev-link a,
62
59
.diffusion-author-link a,
63
60
.diffusion-line-link a {
64
-
font-weight: bold;
61
+
color: {$darkbluetext};
65
62
}
66
63
67
64
.diffusion-rev-link a,
68
65
.diffusion-author-link span,
69
66
.diffusion-author-link a {
70
-
margin: 0 8px;
67
+
margin: 2px 8px 0;
68
+
display: block;
71
69
}
72
70
73
71
.diffusion-blame-link a,
74
72
.diffusion-line-link a {
75
73
/* Give the user a larger click target. */
76
-
display: block;
77
-
padding: 2px 8px;
74
+
display: block;
75
+
padding: 2px 8px;
78
76
}
79
77
80
78
.diffusion-line-link {