@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Removed getElementsByClassName in repositor-crossreference.js
Summary: Used JX.DOM.scry() to locate blocks.
Test Plan: I made the necessary changes, differential is loading diffs as usual. Let me know if I have done it correctly.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin, AnhNhan
Maniphest Tasks: T3007
Differential Revision: https://secure.phabricator.com/D5887
Conflicts:
src/__celerity_resource_map__.php
Conflicts:
src/__celerity_resource_map__.php
authored by
Afaque Hussain
and committed by
epriestley
8ab4b885
13e03c3d
+24
-24
+23
-23
src/__celerity_resource_map__.php
+23
-23
src/__celerity_resource_map__.php
···
2258
2258
),
2259
2259
'javelin-behavior-repository-crossreference' =>
2260
2260
array(
2261
-
'uri' => '/res/4b5fab1c/rsrc/js/application/repository/repository-crossreference.js',
2261
+
'uri' => '/res/d3f9d50b/rsrc/js/application/repository/repository-crossreference.js',
2262
2262
'type' => 'js',
2263
2263
'requires' =>
2264
2264
array(
···
4133
4133
'uri' => '/res/pkg/dd27a69b/differential.pkg.css',
4134
4134
'type' => 'css',
4135
4135
),
4136
-
'27c55b30' =>
4136
+
'77e07ff4' =>
4137
4137
array(
4138
4138
'name' => 'differential.pkg.js',
4139
4139
'symbols' =>
···
4159
4159
18 => 'javelin-behavior-differential-toggle-files',
4160
4160
19 => 'javelin-behavior-differential-user-select',
4161
4161
),
4162
-
'uri' => '/res/pkg/27c55b30/differential.pkg.js',
4162
+
'uri' => '/res/pkg/77e07ff4/differential.pkg.js',
4163
4163
'type' => 'js',
4164
4164
),
4165
4165
'c8ce2d88' =>
···
4256
4256
'aphront-typeahead-control-css' => 'd8236471',
4257
4257
'differential-changeset-view-css' => 'dd27a69b',
4258
4258
'differential-core-view-css' => 'dd27a69b',
4259
-
'differential-inline-comment-editor' => '27c55b30',
4259
+
'differential-inline-comment-editor' => '77e07ff4',
4260
4260
'differential-local-commits-view-css' => 'dd27a69b',
4261
4261
'differential-results-table-css' => 'dd27a69b',
4262
4262
'differential-revision-add-comment-css' => 'dd27a69b',
···
4274
4274
'javelin-behavior-aphlict-dropdown' => '26980a1c',
4275
4275
'javelin-behavior-aphlict-listen' => '26980a1c',
4276
4276
'javelin-behavior-aphront-basic-tokenizer' => '26980a1c',
4277
-
'javelin-behavior-aphront-drag-and-drop' => '27c55b30',
4278
-
'javelin-behavior-aphront-drag-and-drop-textarea' => '27c55b30',
4277
+
'javelin-behavior-aphront-drag-and-drop' => '77e07ff4',
4278
+
'javelin-behavior-aphront-drag-and-drop-textarea' => '77e07ff4',
4279
4279
'javelin-behavior-aphront-form-disable-on-submit' => '26980a1c',
4280
4280
'javelin-behavior-audit-preview' => 'f96657b8',
4281
4281
'javelin-behavior-dark-console' => '4ccfeb47',
4282
4282
'javelin-behavior-device' => '26980a1c',
4283
-
'javelin-behavior-differential-accept-with-errors' => '27c55b30',
4284
-
'javelin-behavior-differential-add-reviewers-and-ccs' => '27c55b30',
4285
-
'javelin-behavior-differential-comment-jump' => '27c55b30',
4286
-
'javelin-behavior-differential-diff-radios' => '27c55b30',
4287
-
'javelin-behavior-differential-dropdown-menus' => '27c55b30',
4288
-
'javelin-behavior-differential-edit-inline-comments' => '27c55b30',
4289
-
'javelin-behavior-differential-feedback-preview' => '27c55b30',
4290
-
'javelin-behavior-differential-keyboard-navigation' => '27c55b30',
4291
-
'javelin-behavior-differential-populate' => '27c55b30',
4292
-
'javelin-behavior-differential-show-more' => '27c55b30',
4293
-
'javelin-behavior-differential-toggle-files' => '27c55b30',
4294
-
'javelin-behavior-differential-user-select' => '27c55b30',
4283
+
'javelin-behavior-differential-accept-with-errors' => '77e07ff4',
4284
+
'javelin-behavior-differential-add-reviewers-and-ccs' => '77e07ff4',
4285
+
'javelin-behavior-differential-comment-jump' => '77e07ff4',
4286
+
'javelin-behavior-differential-diff-radios' => '77e07ff4',
4287
+
'javelin-behavior-differential-dropdown-menus' => '77e07ff4',
4288
+
'javelin-behavior-differential-edit-inline-comments' => '77e07ff4',
4289
+
'javelin-behavior-differential-feedback-preview' => '77e07ff4',
4290
+
'javelin-behavior-differential-keyboard-navigation' => '77e07ff4',
4291
+
'javelin-behavior-differential-populate' => '77e07ff4',
4292
+
'javelin-behavior-differential-show-more' => '77e07ff4',
4293
+
'javelin-behavior-differential-toggle-files' => '77e07ff4',
4294
+
'javelin-behavior-differential-user-select' => '77e07ff4',
4295
4295
'javelin-behavior-diffusion-commit-graph' => 'f96657b8',
4296
4296
'javelin-behavior-diffusion-pull-lastmodified' => 'f96657b8',
4297
4297
'javelin-behavior-error-log' => '4ccfeb47',
···
4299
4299
'javelin-behavior-history-install' => '26980a1c',
4300
4300
'javelin-behavior-konami' => '26980a1c',
4301
4301
'javelin-behavior-lightbox-attachments' => '26980a1c',
4302
-
'javelin-behavior-load-blame' => '27c55b30',
4302
+
'javelin-behavior-load-blame' => '77e07ff4',
4303
4303
'javelin-behavior-maniphest-batch-selector' => 'f85eb6d8',
4304
4304
'javelin-behavior-maniphest-subpriority-editor' => 'f85eb6d8',
4305
4305
'javelin-behavior-maniphest-transaction-controls' => 'f85eb6d8',
···
4310
4310
'javelin-behavior-phabricator-gesture' => '26980a1c',
4311
4311
'javelin-behavior-phabricator-keyboard-shortcuts' => '26980a1c',
4312
4312
'javelin-behavior-phabricator-nav' => '26980a1c',
4313
-
'javelin-behavior-phabricator-object-selector' => '27c55b30',
4313
+
'javelin-behavior-phabricator-object-selector' => '77e07ff4',
4314
4314
'javelin-behavior-phabricator-oncopy' => '26980a1c',
4315
4315
'javelin-behavior-phabricator-remarkup-assist' => '26980a1c',
4316
4316
'javelin-behavior-phabricator-reveal-content' => '26980a1c',
···
4318
4318
'javelin-behavior-phabricator-tooltips' => '26980a1c',
4319
4319
'javelin-behavior-phabricator-watch-anchor' => '26980a1c',
4320
4320
'javelin-behavior-refresh-csrf' => '26980a1c',
4321
-
'javelin-behavior-repository-crossreference' => '27c55b30',
4321
+
'javelin-behavior-repository-crossreference' => '77e07ff4',
4322
4322
'javelin-behavior-toggle-class' => '26980a1c',
4323
4323
'javelin-behavior-workflow' => '26980a1c',
4324
4324
'javelin-dom' => '202a3dd0',
···
4348
4348
'phabricator-core-css' => 'd8236471',
4349
4349
'phabricator-crumbs-view-css' => 'd8236471',
4350
4350
'phabricator-directory-css' => 'd8236471',
4351
-
'phabricator-drag-and-drop-file-upload' => '27c55b30',
4351
+
'phabricator-drag-and-drop-file-upload' => '77e07ff4',
4352
4352
'phabricator-dropdown-menu' => '26980a1c',
4353
4353
'phabricator-file-upload' => '26980a1c',
4354
4354
'phabricator-filetree-view-css' => 'd8236471',
···
4370
4370
'phabricator-prefab' => '26980a1c',
4371
4371
'phabricator-project-tag-css' => '6b1fccc6',
4372
4372
'phabricator-remarkup-css' => 'd8236471',
4373
-
'phabricator-shaped-request' => '27c55b30',
4373
+
'phabricator-shaped-request' => '77e07ff4',
4374
4374
'phabricator-side-menu-view-css' => 'd8236471',
4375
4375
'phabricator-standard-page-view' => 'd8236471',
4376
4376
'phabricator-textareautils' => '26980a1c',
+1
-1
webroot/rsrc/js/application/repository/repository-crossreference.js
+1
-1
webroot/rsrc/js/application/repository/repository-crossreference.js
···
55
55
}
56
56
57
57
function linkAll(section) {
58
-
var blocks = section.getElementsByClassName('remarkup-code-block');
58
+
var blocks = JX.DOM.scry(document.body, 'div', 'remarkup-code-block');
59
59
for (var i = 0; i < blocks.length; ++i) {
60
60
if (blocks[i].hasAttribute('data-code-lang')) {
61
61
var lang = blocks[i].getAttribute('data-code-lang');