@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add NEEDS_REVISION support to DifferentialRevisionQuery
Reviewed by: epriestley
See: https://github.com/facebook/phabricator/pull/370
authored by
Kieran Brownlees
and committed by
epriestley
8b07c498
1ab7622e
+17
-8
+17
-8
src/applications/differential/query/DifferentialRevisionQuery.php
+17
-8
src/applications/differential/query/DifferentialRevisionQuery.php
···
17
17
18
18
private $pathIDs = array();
19
19
20
-
private $status = 'status-any';
21
-
const STATUS_ANY = 'status-any';
22
-
const STATUS_OPEN = 'status-open';
23
-
const STATUS_ACCEPTED = 'status-accepted';
24
-
const STATUS_NEEDS_REVIEW = 'status-needs-review';
25
-
const STATUS_CLOSED = 'status-closed'; // NOTE: Same as 'committed'.
26
-
const STATUS_COMMITTED = 'status-committed'; // TODO: Remove.
27
-
const STATUS_ABANDONED = 'status-abandoned';
20
+
private $status = 'status-any';
21
+
const STATUS_ANY = 'status-any';
22
+
const STATUS_OPEN = 'status-open';
23
+
const STATUS_ACCEPTED = 'status-accepted';
24
+
const STATUS_NEEDS_REVIEW = 'status-needs-review';
25
+
const STATUS_NEEDS_REVISION = 'status-needs-revision';
26
+
const STATUS_CLOSED = 'status-closed'; // NOTE: Same as 'committed'
27
+
const STATUS_COMMITTED = 'status-committed'; // TODO: Remove.
28
+
const STATUS_ABANDONED = 'status-abandoned';
28
29
29
30
private $authors = array();
30
31
private $draftAuthors = array();
···
658
659
'r.status IN (%Ld)',
659
660
array(
660
661
ArcanistDifferentialRevisionStatus::NEEDS_REVIEW,
662
+
));
663
+
break;
664
+
case self::STATUS_NEEDS_REVISION:
665
+
$where[] = qsprintf(
666
+
$conn_r,
667
+
'r.status IN (%Ld)',
668
+
array(
669
+
ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
661
670
));
662
671
break;
663
672
case self::STATUS_ACCEPTED: