@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Replace some ambiguous "owner" strings with "assignee" or "author"
Summary:
Reduce confusion whether "owner" means "author" or "assignee" by being explicit whenever possible.
This change only touches user-visible strings.
It does not touch internal variable names.
This change does not change current phrasing for sessions, credentials, packages, drydock leases, etc. as there is less or no ambiguity.
This change does not touch PhabricatorPeopleNoOwnerDatasource as we do not want to change semantics and its description is clear enough.
This change does not touch strings for revisions as that concept is more blurry: "If a revision needs review, the owners are the reviewers. Otherwise, the owner is the author (e.g., accepted, rejected, closed)."
Closes T15917
Test Plan: Look at strings, read code.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15917
Differential Revision: https://we.phorge.it/D26488
+23
-23
+1
-1
src/applications/herald/storage/HeraldRule.php
+1
-1
src/applications/herald/storage/HeraldRule.php
···
408
408
} else if ($this->isObjectRule()) {
409
409
return pht('Object rules inherit the edit policies of their objects.');
410
410
} else {
411
-
return pht('A personal rule can only be edited by its owner.');
411
+
return pht('A personal rule can only be edited by its author.');
412
412
}
413
413
}
414
414
+3
-3
src/applications/herald/storage/transcript/HeraldRuleResult.php
+3
-3
src/applications/herald/storage/transcript/HeraldRuleResult.php
···
149
149
self::RESULT_OWNER => array(
150
150
'match' => null,
151
151
'apply' => false,
152
-
'name' => pht('Rule Owner'),
152
+
'name' => pht('Rule Author'),
153
153
'description' => pht(
154
154
'Rule failed automatically because it is a personal rule and '.
155
-
'its owner is invalid or disabled.'),
155
+
'its author is invalid or disabled.'),
156
156
'icon' => 'fa-times-circle',
157
157
'color.icon' => 'red',
158
158
),
···
162
162
'name' => pht('View Policy'),
163
163
'description' => pht(
164
164
'Rule failed automatically because it is a personal rule and '.
165
-
'its owner does not have permission to view the object.'),
165
+
'its author does not have permission to view the object.'),
166
166
'icon' => 'fa-times-circle',
167
167
'color.icon' => 'red',
168
168
),
+1
-1
src/applications/maniphest/editor/ManiphestEditEngine.php
+1
-1
src/applications/maniphest/editor/ManiphestEditEngine.php
···
202
202
->setDescription(pht('User who is responsible for the task.'))
203
203
->setConduitDescription(pht('Reassign the task.'))
204
204
->setConduitTypeDescription(
205
-
pht('New task owner, or `null` to unassign.'))
205
+
pht('New task assignee, or `null` to unassign.'))
206
206
->setTransactionType(ManiphestTaskOwnerTransaction::TRANSACTIONTYPE)
207
207
->setIsCopyable(true)
208
208
->setIsNullable(true)
+6
-6
src/applications/maniphest/editor/ManiphestTransactionEditor.php
+6
-6
src/applications/maniphest/editor/ManiphestTransactionEditor.php
···
177
177
ManiphestTransaction::MAILTAG_STATUS =>
178
178
pht("A task's status changes."),
179
179
ManiphestTransaction::MAILTAG_OWNER =>
180
-
pht("A task's owner changes."),
180
+
pht("A task's assignee changes."),
181
181
ManiphestTransaction::MAILTAG_PRIORITY =>
182
182
pht("A task's priority changes."),
183
183
ManiphestTransaction::MAILTAG_CC =>
···
829
829
$message = pht(
830
830
'You can not lock this task and unassign it at the same time '.
831
831
'because no one will be able to edit it anymore. Lock the task '.
832
-
'or remove the owner, but not both.');
832
+
'or remove the assignee, but not both.');
833
833
$problem_xaction = $status_xaction;
834
834
} else if ($status_changed) {
835
835
$message = pht(
836
-
'You can not lock this task because it does not have an owner. '.
836
+
'You can not lock this task because it does not have an assignee. '.
837
837
'No one would be able to edit the task. Assign the task to an '.
838
-
'owner before locking it.');
838
+
'assignee before locking it.');
839
839
$problem_xaction = $status_xaction;
840
840
} else if ($owner_changed) {
841
841
$message = pht(
842
-
'You can not remove the owner of this task because it is locked '.
842
+
'You can not remove the assignee of this task because it is locked '.
843
843
'and no one would be able to edit the task. Reassign the task or '.
844
-
'unlock it before removing the owner.');
844
+
'unlock it before removing the assignee.');
845
845
$problem_xaction = $owner_xaction;
846
846
} else {
847
847
// If the task was already broken, we don't have a transaction to
+4
-4
src/applications/maniphest/policy/ManiphestTaskPolicyCodex.php
+4
-4
src/applications/maniphest/policy/ManiphestTaskPolicyCodex.php
···
46
46
PhabricatorPolicyCapability::CAN_EDIT,
47
47
))
48
48
->setDescription(
49
-
pht('The owner of a task can always view and edit it.'));
49
+
pht('The assignee of a task can always view and edit it.'));
50
50
51
51
$rules[] = $this->newRule()
52
52
->setCapabilities(
···
56
56
->setIsActive($object->areEditsLocked())
57
57
->setDescription(
58
58
pht(
59
-
'Tasks with edits locked may only be edited by their owner.'));
59
+
'Tasks with edits locked may only be edited by their assignee.'));
60
60
61
61
return $rules;
62
62
}
···
64
64
public function getPolicyForEdit($capability) {
65
65
66
66
// When a task has its edits locked, the effective edit policy is locked
67
-
// to "No One". However, the task owner may still bypass the lock and edit
68
-
// the task. When they do, we want the control in the UI to have the
67
+
// to "No One". However, the task assignee may still bypass the lock and
68
+
// edit the task. When they do, we want the control in the UI to have the
69
69
// correct value. Return the real value stored on the object.
70
70
71
71
switch ($capability) {
+2
-2
src/applications/maniphest/storage/ManiphestTask.php
+2
-2
src/applications/maniphest/storage/ManiphestTask.php
···
345
345
}
346
346
347
347
public function hasAutomaticCapability($capability, PhabricatorUser $user) {
348
-
// The owner of a task can always view and edit it.
348
+
// The owner (assignee) of a task can always view and edit it.
349
349
$owner_phid = $this->getOwnerPHID();
350
350
if ($owner_phid) {
351
351
$user_phid = $user->getPHID();
···
445
445
id(new PhabricatorConduitSearchFieldSpecification())
446
446
->setKey('ownerPHID')
447
447
->setType('phid?')
448
-
->setDescription(pht('Current task owner, if task is assigned.')),
448
+
->setDescription(pht('Current task assignee, if task is assigned.')),
449
449
id(new PhabricatorConduitSearchFieldSpecification())
450
450
->setKey('status')
451
451
->setType('map<string, wild>')
+1
-1
src/applications/maniphest/storage/ManiphestTransaction.php
+1
-1
src/applications/maniphest/storage/ManiphestTransaction.php
···
202
202
case ManiphestTaskStatusTransaction::TRANSACTIONTYPE:
203
203
return pht('The task already has the selected status.');
204
204
case ManiphestTaskOwnerTransaction::TRANSACTIONTYPE:
205
-
return pht('The task already has the selected owner.');
205
+
return pht('The task already has the selected assignee.');
206
206
case ManiphestTaskPriorityTransaction::TRANSACTIONTYPE:
207
207
return pht('The task already has the selected priority.');
208
208
}
+1
-1
src/applications/pholio/storage/PholioMock.php
+1
-1
src/applications/pholio/storage/PholioMock.php
+1
-1
src/applications/phurl/storage/PhabricatorPhurlURL.php
+1
-1
src/applications/phurl/storage/PhabricatorPhurlURL.php
···
152
152
}
153
153
154
154
public function describeAutomaticCapability($capability) {
155
-
return pht('The owner of a URL can always view and edit it.');
155
+
return pht('The author of a URL can always view and edit it.');
156
156
}
157
157
158
158
/* -( PhabricatorApplicationTransactionInterface )------------------------- */
+2
-2
src/applications/slowvote/constants/SlowvotePollResponseVisibility.php
+2
-2
src/applications/slowvote/constants/SlowvotePollResponseVisibility.php
···
66
66
'name.edit' => pht('Require a vote to see the responses'),
67
67
),
68
68
self::RESPONSES_OWNER => array(
69
-
'name' => pht('Owner'),
70
-
'name.edit' => pht('Only the poll owner can see the responses'),
69
+
'name' => pht('Author'),
70
+
'name.edit' => pht('Only the poll author can see the responses'),
71
71
),
72
72
);
73
73
}
+1
-1
src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
+1
-1
src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
···
211
211
public function describeAutomaticCapability($capability) {
212
212
switch ($capability) {
213
213
case PhabricatorPolicyCapability::CAN_EDIT:
214
-
return pht('Only the owner of a bulk job can edit it.');
214
+
return pht('Only the author of a bulk job can edit it.');
215
215
default:
216
216
return null;
217
217
}