recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Rename `PhabricatorPolicyRule` subclasses for consistency

Summary: Ref T5655.

Test Plan: `arc lint` and `arc unit`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D11131

Joshua Spence 8b756177 4e28de07

+18 -22
+10 -10
src/__phutil_library_map__.php
··· 1228 1228 'PhabricatorActionListView' => 'view/layout/PhabricatorActionListView.php', 1229 1229 'PhabricatorActionView' => 'view/layout/PhabricatorActionView.php', 1230 1230 'PhabricatorActivitySettingsPanel' => 'applications/settings/panel/PhabricatorActivitySettingsPanel.php', 1231 + 'PhabricatorAdministratorsPolicyRule' => 'applications/policy/rule/PhabricatorAdministratorsPolicyRule.php', 1231 1232 'PhabricatorAllCapsTranslation' => 'infrastructure/internationalization/translation/PhabricatorAllCapsTranslation.php', 1232 1233 'PhabricatorAlmanacApplication' => 'applications/almanac/application/PhabricatorAlmanacApplication.php', 1233 1234 'PhabricatorAmazonAuthProvider' => 'applications/auth/provider/PhabricatorAmazonAuthProvider.php', ··· 1839 1840 'PhabricatorLegalpadApplication' => 'applications/legalpad/application/PhabricatorLegalpadApplication.php', 1840 1841 'PhabricatorLegalpadConfigOptions' => 'applications/legalpad/config/PhabricatorLegalpadConfigOptions.php', 1841 1842 'PhabricatorLegalpadDocumentPHIDType' => 'applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php', 1843 + 'PhabricatorLegalpadSignaturePolicyRule' => 'applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php', 1842 1844 'PhabricatorLipsumArtist' => 'applications/lipsum/image/PhabricatorLipsumArtist.php', 1843 1845 'PhabricatorLipsumGenerateWorkflow' => 'applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php', 1844 1846 'PhabricatorLipsumManagementWorkflow' => 'applications/lipsum/management/PhabricatorLipsumManagementWorkflow.php', ··· 1848 1850 'PhabricatorLocalDiskFileStorageEngine' => 'applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php', 1849 1851 'PhabricatorLocalTimeTestCase' => 'view/__tests__/PhabricatorLocalTimeTestCase.php', 1850 1852 'PhabricatorLogoutController' => 'applications/auth/controller/PhabricatorLogoutController.php', 1853 + 'PhabricatorLunarPhasePolicyRule' => 'applications/policy/rule/PhabricatorLunarPhasePolicyRule.php', 1851 1854 'PhabricatorMacroApplication' => 'applications/macro/application/PhabricatorMacroApplication.php', 1852 1855 'PhabricatorMacroAudioController' => 'applications/macro/controller/PhabricatorMacroAudioController.php', 1853 1856 'PhabricatorMacroCommentController' => 'applications/macro/controller/PhabricatorMacroCommentController.php', ··· 2123 2126 'PhabricatorPolicyPHIDTypePolicy' => 'applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php', 2124 2127 'PhabricatorPolicyQuery' => 'applications/policy/query/PhabricatorPolicyQuery.php', 2125 2128 'PhabricatorPolicyRule' => 'applications/policy/rule/PhabricatorPolicyRule.php', 2126 - 'PhabricatorPolicyRuleAdministrators' => 'applications/policy/rule/PhabricatorPolicyRuleAdministrators.php', 2127 - 'PhabricatorPolicyRuleLegalpadSignature' => 'applications/policy/rule/PhabricatorPolicyRuleLegalpadSignature.php', 2128 - 'PhabricatorPolicyRuleLunarPhase' => 'applications/policy/rule/PhabricatorPolicyRuleLunarPhase.php', 2129 - 'PhabricatorPolicyRuleProjects' => 'applications/policy/rule/PhabricatorPolicyRuleProjects.php', 2130 - 'PhabricatorPolicyRuleUsers' => 'applications/policy/rule/PhabricatorPolicyRuleUsers.php', 2131 2129 'PhabricatorPolicyTestCase' => 'applications/policy/__tests__/PhabricatorPolicyTestCase.php', 2132 2130 'PhabricatorPolicyTestObject' => 'applications/policy/__tests__/PhabricatorPolicyTestObject.php', 2133 2131 'PhabricatorPolicyType' => 'applications/policy/constants/PhabricatorPolicyType.php', ··· 2194 2192 'PhabricatorProjectUpdateController' => 'applications/project/controller/PhabricatorProjectUpdateController.php', 2195 2193 'PhabricatorProjectWatchController' => 'applications/project/controller/PhabricatorProjectWatchController.php', 2196 2194 'PhabricatorProjectWikiExplainController' => 'applications/project/controller/PhabricatorProjectWikiExplainController.php', 2195 + 'PhabricatorProjectsPolicyRule' => 'applications/policy/rule/PhabricatorProjectsPolicyRule.php', 2197 2196 'PhabricatorQuery' => 'infrastructure/query/PhabricatorQuery.php', 2198 2197 'PhabricatorRecaptchaConfigOptions' => 'applications/config/option/PhabricatorRecaptchaConfigOptions.php', 2199 2198 'PhabricatorRedirectController' => 'applications/base/controller/PhabricatorRedirectController.php', ··· 2543 2542 'PhabricatorUserTestCase' => 'applications/people/storage/__tests__/PhabricatorUserTestCase.php', 2544 2543 'PhabricatorUserTitleField' => 'applications/people/customfield/PhabricatorUserTitleField.php', 2545 2544 'PhabricatorUserTransaction' => 'applications/people/storage/PhabricatorUserTransaction.php', 2545 + 'PhabricatorUsersPolicyRule' => 'applications/policy/rule/PhabricatorUsersPolicyRule.php', 2546 2546 'PhabricatorVCSResponse' => 'applications/repository/response/PhabricatorVCSResponse.php', 2547 2547 'PhabricatorWordPressAuthProvider' => 'applications/auth/provider/PhabricatorWordPressAuthProvider.php', 2548 2548 'PhabricatorWorker' => 'infrastructure/daemon/workers/PhabricatorWorker.php', ··· 4365 4365 'PhabricatorActionListView' => 'AphrontView', 4366 4366 'PhabricatorActionView' => 'AphrontView', 4367 4367 'PhabricatorActivitySettingsPanel' => 'PhabricatorSettingsPanel', 4368 + 'PhabricatorAdministratorsPolicyRule' => 'PhabricatorPolicyRule', 4368 4369 'PhabricatorAllCapsTranslation' => 'PhabricatorTranslation', 4369 4370 'PhabricatorAlmanacApplication' => 'PhabricatorApplication', 4370 4371 'PhabricatorAmazonAuthProvider' => 'PhabricatorOAuth2AuthProvider', ··· 5022 5023 'PhabricatorLegalpadApplication' => 'PhabricatorApplication', 5023 5024 'PhabricatorLegalpadConfigOptions' => 'PhabricatorApplicationConfigOptions', 5024 5025 'PhabricatorLegalpadDocumentPHIDType' => 'PhabricatorPHIDType', 5026 + 'PhabricatorLegalpadSignaturePolicyRule' => 'PhabricatorPolicyRule', 5025 5027 'PhabricatorLipsumGenerateWorkflow' => 'PhabricatorLipsumManagementWorkflow', 5026 5028 'PhabricatorLipsumManagementWorkflow' => 'PhabricatorManagementWorkflow', 5027 5029 'PhabricatorLipsumMondrianArtist' => 'PhabricatorLipsumArtist', ··· 5029 5031 'PhabricatorLocalDiskFileStorageEngine' => 'PhabricatorFileStorageEngine', 5030 5032 'PhabricatorLocalTimeTestCase' => 'PhabricatorTestCase', 5031 5033 'PhabricatorLogoutController' => 'PhabricatorAuthController', 5034 + 'PhabricatorLunarPhasePolicyRule' => 'PhabricatorPolicyRule', 5032 5035 'PhabricatorMacroApplication' => 'PhabricatorApplication', 5033 5036 'PhabricatorMacroAudioController' => 'PhabricatorMacroController', 5034 5037 'PhabricatorMacroCommentController' => 'PhabricatorMacroController', ··· 5304 5307 'PhabricatorPolicyManagementWorkflow' => 'PhabricatorManagementWorkflow', 5305 5308 'PhabricatorPolicyPHIDTypePolicy' => 'PhabricatorPHIDType', 5306 5309 'PhabricatorPolicyQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 5307 - 'PhabricatorPolicyRuleAdministrators' => 'PhabricatorPolicyRule', 5308 - 'PhabricatorPolicyRuleLegalpadSignature' => 'PhabricatorPolicyRule', 5309 - 'PhabricatorPolicyRuleLunarPhase' => 'PhabricatorPolicyRule', 5310 - 'PhabricatorPolicyRuleProjects' => 'PhabricatorPolicyRule', 5311 - 'PhabricatorPolicyRuleUsers' => 'PhabricatorPolicyRule', 5312 5310 'PhabricatorPolicyTestCase' => 'PhabricatorTestCase', 5313 5311 'PhabricatorPolicyTestObject' => 'PhabricatorPolicyInterface', 5314 5312 'PhabricatorPolicyType' => 'PhabricatorPolicyConstants', ··· 5395 5393 'PhabricatorProjectUpdateController' => 'PhabricatorProjectController', 5396 5394 'PhabricatorProjectWatchController' => 'PhabricatorProjectController', 5397 5395 'PhabricatorProjectWikiExplainController' => 'PhabricatorProjectController', 5396 + 'PhabricatorProjectsPolicyRule' => 'PhabricatorPolicyRule', 5398 5397 'PhabricatorRecaptchaConfigOptions' => 'PhabricatorApplicationConfigOptions', 5399 5398 'PhabricatorRedirectController' => 'PhabricatorController', 5400 5399 'PhabricatorRefreshCSRFController' => 'PhabricatorAuthController', ··· 5778 5777 'PhabricatorUserTestCase' => 'PhabricatorTestCase', 5779 5778 'PhabricatorUserTitleField' => 'PhabricatorUserCustomField', 5780 5779 'PhabricatorUserTransaction' => 'PhabricatorApplicationTransaction', 5780 + 'PhabricatorUsersPolicyRule' => 'PhabricatorPolicyRule', 5781 5781 'PhabricatorVCSResponse' => 'AphrontResponse', 5782 5782 'PhabricatorWordPressAuthProvider' => 'PhabricatorOAuth2AuthProvider', 5783 5783 'PhabricatorWorkerActiveTask' => 'PhabricatorWorkerTask',
+3 -3
src/applications/policy/__tests__/PhabricatorPolicyDataTestCase.php
··· 48 48 array( 49 49 array( 50 50 'action' => PhabricatorPolicy::ACTION_ALLOW, 51 - 'rule' => 'PhabricatorPolicyRuleUsers', 51 + 'rule' => 'PhabricatorUsersPolicyRule', 52 52 'value' => array($user_a->getPHID()), 53 53 ), 54 54 )) ··· 84 84 array( 85 85 array( 86 86 'action' => PhabricatorPolicy::ACTION_ALLOW, 87 - 'rule' => 'PhabricatorPolicyRuleAdministrators', 87 + 'rule' => 'PhabricatorAdministratorsPolicyRule', 88 88 'value' => null, 89 89 ), 90 90 )) ··· 118 118 array( 119 119 array( 120 120 'action' => PhabricatorPolicy::ACTION_ALLOW, 121 - 'rule' => 'PhabricatorPolicyRuleLunarPhase', 121 + 'rule' => 'PhabricatorLunarPhasePolicyRule', 122 122 'value' => 'new', 123 123 ), 124 124 ))
+1 -2
src/applications/policy/rule/PhabricatorPolicyRuleAdministrators.php src/applications/policy/rule/PhabricatorAdministratorsPolicyRule.php
··· 1 1 <?php 2 2 3 - final class PhabricatorPolicyRuleAdministrators 4 - extends PhabricatorPolicyRule { 3 + final class PhabricatorAdministratorsPolicyRule extends PhabricatorPolicyRule { 5 4 6 5 public function getRuleDescription() { 7 6 return pht('administrators');
+1 -1
src/applications/policy/rule/PhabricatorPolicyRuleLegalpadSignature.php src/applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php
··· 1 1 <?php 2 2 3 - final class PhabricatorPolicyRuleLegalpadSignature 3 + final class PhabricatorLegalpadSignaturePolicyRule 4 4 extends PhabricatorPolicyRule { 5 5 6 6 private $signatures = array();
+1 -2
src/applications/policy/rule/PhabricatorPolicyRuleLunarPhase.php src/applications/policy/rule/PhabricatorLunarPhasePolicyRule.php
··· 1 1 <?php 2 2 3 - final class PhabricatorPolicyRuleLunarPhase 4 - extends PhabricatorPolicyRule { 3 + final class PhabricatorLunarPhasePolicyRule extends PhabricatorPolicyRule { 5 4 6 5 const PHASE_FULL = 'full'; 7 6 const PHASE_NEW = 'new';
+1 -2
src/applications/policy/rule/PhabricatorPolicyRuleProjects.php src/applications/policy/rule/PhabricatorProjectsPolicyRule.php
··· 1 1 <?php 2 2 3 - final class PhabricatorPolicyRuleProjects 4 - extends PhabricatorPolicyRule { 3 + final class PhabricatorProjectsPolicyRule extends PhabricatorPolicyRule { 5 4 6 5 private $memberships = array(); 7 6
+1 -2
src/applications/policy/rule/PhabricatorPolicyRuleUsers.php src/applications/policy/rule/PhabricatorUsersPolicyRule.php
··· 1 1 <?php 2 2 3 - final class PhabricatorPolicyRuleUsers 4 - extends PhabricatorPolicyRule { 3 + final class PhabricatorUsersPolicyRule extends PhabricatorPolicyRule { 5 4 6 5 public function getRuleDescription() { 7 6 return pht('users');