recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix warning panel on large commits

Summary: The warning panel on large commits in diffusion was being overrun with other styles. Fixes T3952

Test Plan: test on a large commit

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T3952

Differential Revision: https://secure.phabricator.com/D7456

Chad Little 8babbb92 24a5d050

+54 -51
+46 -46
src/__celerity_resource_map__.php
··· 859 859 ), 860 860 'aphront-error-view-css' => 861 861 array( 862 - 'uri' => '/res/07a74e07/rsrc/css/aphront/error-view.css', 862 + 'uri' => '/res/cb571901/rsrc/css/aphront/error-view.css', 863 863 'type' => 'css', 864 864 'requires' => 865 865 array( ··· 4318 4318 ), array( 4319 4319 'packages' => 4320 4320 array( 4321 - 'e3e5a752' => 4321 + 'b05e33c6' => 4322 4322 array( 4323 4323 'name' => 'core.pkg.css', 4324 4324 'symbols' => ··· 4367 4367 41 => 'phabricator-tag-view-css', 4368 4368 42 => 'phui-list-view-css', 4369 4369 ), 4370 - 'uri' => '/res/pkg/e3e5a752/core.pkg.css', 4370 + 'uri' => '/res/pkg/b05e33c6/core.pkg.css', 4371 4371 'type' => 'css', 4372 4372 ), 4373 4373 '2c1dba03' => ··· 4559 4559 ), 4560 4560 'reverse' => 4561 4561 array( 4562 - 'aphront-dialog-view-css' => 'e3e5a752', 4563 - 'aphront-error-view-css' => 'e3e5a752', 4564 - 'aphront-list-filter-view-css' => 'e3e5a752', 4565 - 'aphront-pager-view-css' => 'e3e5a752', 4566 - 'aphront-panel-view-css' => 'e3e5a752', 4567 - 'aphront-table-view-css' => 'e3e5a752', 4568 - 'aphront-tokenizer-control-css' => 'e3e5a752', 4569 - 'aphront-tooltip-css' => 'e3e5a752', 4570 - 'aphront-typeahead-control-css' => 'e3e5a752', 4562 + 'aphront-dialog-view-css' => 'b05e33c6', 4563 + 'aphront-error-view-css' => 'b05e33c6', 4564 + 'aphront-list-filter-view-css' => 'b05e33c6', 4565 + 'aphront-pager-view-css' => 'b05e33c6', 4566 + 'aphront-panel-view-css' => 'b05e33c6', 4567 + 'aphront-table-view-css' => 'b05e33c6', 4568 + 'aphront-tokenizer-control-css' => 'b05e33c6', 4569 + 'aphront-tooltip-css' => 'b05e33c6', 4570 + 'aphront-typeahead-control-css' => 'b05e33c6', 4571 4571 'differential-changeset-view-css' => '1084b12b', 4572 4572 'differential-core-view-css' => '1084b12b', 4573 4573 'differential-inline-comment-editor' => '5e9e5c4e', ··· 4581 4581 'differential-table-of-contents-css' => '1084b12b', 4582 4582 'diffusion-commit-view-css' => '270f4eb4', 4583 4583 'diffusion-icons-css' => '270f4eb4', 4584 - 'global-drag-and-drop-css' => 'e3e5a752', 4584 + 'global-drag-and-drop-css' => 'b05e33c6', 4585 4585 'inline-comment-summary-css' => '1084b12b', 4586 4586 'javelin-aphlict' => '2c1dba03', 4587 4587 'javelin-behavior' => '3e3be199', ··· 4656 4656 'javelin-util' => '3e3be199', 4657 4657 'javelin-vector' => '3e3be199', 4658 4658 'javelin-workflow' => '3e3be199', 4659 - 'lightbox-attachment-css' => 'e3e5a752', 4659 + 'lightbox-attachment-css' => 'b05e33c6', 4660 4660 'maniphest-task-summary-css' => '49898640', 4661 - 'phabricator-action-list-view-css' => 'e3e5a752', 4662 - 'phabricator-application-launch-view-css' => 'e3e5a752', 4661 + 'phabricator-action-list-view-css' => 'b05e33c6', 4662 + 'phabricator-application-launch-view-css' => 'b05e33c6', 4663 4663 'phabricator-busy' => '2c1dba03', 4664 4664 'phabricator-content-source-view-css' => '1084b12b', 4665 - 'phabricator-core-css' => 'e3e5a752', 4666 - 'phabricator-crumbs-view-css' => 'e3e5a752', 4665 + 'phabricator-core-css' => 'b05e33c6', 4666 + 'phabricator-crumbs-view-css' => 'b05e33c6', 4667 4667 'phabricator-drag-and-drop-file-upload' => '5e9e5c4e', 4668 4668 'phabricator-dropdown-menu' => '2c1dba03', 4669 4669 'phabricator-file-upload' => '2c1dba03', 4670 - 'phabricator-filetree-view-css' => 'e3e5a752', 4671 - 'phabricator-flag-css' => 'e3e5a752', 4670 + 'phabricator-filetree-view-css' => 'b05e33c6', 4671 + 'phabricator-flag-css' => 'b05e33c6', 4672 4672 'phabricator-hovercard' => '2c1dba03', 4673 - 'phabricator-jump-nav' => 'e3e5a752', 4673 + 'phabricator-jump-nav' => 'b05e33c6', 4674 4674 'phabricator-keyboard-shortcut' => '2c1dba03', 4675 4675 'phabricator-keyboard-shortcut-manager' => '2c1dba03', 4676 - 'phabricator-main-menu-view' => 'e3e5a752', 4676 + 'phabricator-main-menu-view' => 'b05e33c6', 4677 4677 'phabricator-menu-item' => '2c1dba03', 4678 - 'phabricator-nav-view-css' => 'e3e5a752', 4678 + 'phabricator-nav-view-css' => 'b05e33c6', 4679 4679 'phabricator-notification' => '2c1dba03', 4680 - 'phabricator-notification-css' => 'e3e5a752', 4681 - 'phabricator-notification-menu-css' => 'e3e5a752', 4680 + 'phabricator-notification-css' => 'b05e33c6', 4681 + 'phabricator-notification-menu-css' => 'b05e33c6', 4682 4682 'phabricator-object-selector-css' => '1084b12b', 4683 4683 'phabricator-phtize' => '2c1dba03', 4684 4684 'phabricator-prefab' => '2c1dba03', 4685 4685 'phabricator-project-tag-css' => '49898640', 4686 - 'phabricator-remarkup-css' => 'e3e5a752', 4686 + 'phabricator-remarkup-css' => 'b05e33c6', 4687 4687 'phabricator-shaped-request' => '5e9e5c4e', 4688 - 'phabricator-side-menu-view-css' => 'e3e5a752', 4689 - 'phabricator-standard-page-view' => 'e3e5a752', 4690 - 'phabricator-tag-view-css' => 'e3e5a752', 4688 + 'phabricator-side-menu-view-css' => 'b05e33c6', 4689 + 'phabricator-standard-page-view' => 'b05e33c6', 4690 + 'phabricator-tag-view-css' => 'b05e33c6', 4691 4691 'phabricator-textareautils' => '2c1dba03', 4692 4692 'phabricator-tooltip' => '2c1dba03', 4693 - 'phabricator-transaction-view-css' => 'e3e5a752', 4694 - 'phabricator-zindex-css' => 'e3e5a752', 4695 - 'phui-button-css' => 'e3e5a752', 4696 - 'phui-form-css' => 'e3e5a752', 4697 - 'phui-form-view-css' => 'e3e5a752', 4698 - 'phui-header-view-css' => 'e3e5a752', 4699 - 'phui-icon-view-css' => 'e3e5a752', 4700 - 'phui-list-view-css' => 'e3e5a752', 4701 - 'phui-object-item-list-view-css' => 'e3e5a752', 4702 - 'phui-property-list-view-css' => 'e3e5a752', 4703 - 'phui-spacing-css' => 'e3e5a752', 4704 - 'sprite-apps-large-css' => 'e3e5a752', 4705 - 'sprite-gradient-css' => 'e3e5a752', 4706 - 'sprite-icons-css' => 'e3e5a752', 4707 - 'sprite-menu-css' => 'e3e5a752', 4708 - 'sprite-status-css' => 'e3e5a752', 4709 - 'syntax-highlighting-css' => 'e3e5a752', 4693 + 'phabricator-transaction-view-css' => 'b05e33c6', 4694 + 'phabricator-zindex-css' => 'b05e33c6', 4695 + 'phui-button-css' => 'b05e33c6', 4696 + 'phui-form-css' => 'b05e33c6', 4697 + 'phui-form-view-css' => 'b05e33c6', 4698 + 'phui-header-view-css' => 'b05e33c6', 4699 + 'phui-icon-view-css' => 'b05e33c6', 4700 + 'phui-list-view-css' => 'b05e33c6', 4701 + 'phui-object-item-list-view-css' => 'b05e33c6', 4702 + 'phui-property-list-view-css' => 'b05e33c6', 4703 + 'phui-spacing-css' => 'b05e33c6', 4704 + 'sprite-apps-large-css' => 'b05e33c6', 4705 + 'sprite-gradient-css' => 'b05e33c6', 4706 + 'sprite-icons-css' => 'b05e33c6', 4707 + 'sprite-menu-css' => 'b05e33c6', 4708 + 'sprite-status-css' => 'b05e33c6', 4709 + 'syntax-highlighting-css' => 'b05e33c6', 4710 4710 ), 4711 4711 ));
+2 -4
src/applications/diffusion/controller/DiffusionCommitController.php
··· 252 252 $warning_view = id(new AphrontErrorView()) 253 253 ->setSeverity(AphrontErrorView::SEVERITY_WARNING) 254 254 ->setTitle('Very Large Commit') 255 - ->appendChild(phutil_tag( 256 - 'p', 257 - array(), 258 - pht("This commit is very large. Load each file individually."))); 255 + ->appendChild( 256 + pht("This commit is very large. Load each file individually.")); 259 257 260 258 $change_panel->appendChild($warning_view); 261 259 $change_panel->addButton($show_all_button);
+6 -1
webroot/rsrc/css/aphront/error-view.css
··· 27 27 padding: 12px; 28 28 } 29 29 30 - .aphront-error-view-head { 30 + .aphront-panel-plain .aphront-error-view { 31 + margin-left: 0; 32 + margin-right: 0; 33 + } 34 + 35 + h1.aphront-error-view-head { 31 36 padding: 10px 10px 0 10px; 32 37 font-weight: bold; 33 38 color: {$darkgreytext};