@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Only associate branch with task if maniphest is enabled
Summary:
Previously, maniphest tasks would get upated by diffs on branches
with tasky names, even if maniphest was disabled.
Test Plan:
Tested createing a diff in sandbox with maniphest disabled, on a
git branch named using the format "t###". Without this change,
if there happened to be a task in the maniphest DB which matched,
it was updated an email was sent to users.
Reviewers: epriestley
Reviewed By: epriestley
CC: wez, slawekbiel, whhone, Korvin, aran
Differential Revision: https://secure.phabricator.com/D6881
+5
+5
src/applications/differential/field/specification/DifferentialBranchFieldSpecification.php
+5
src/applications/differential/field/specification/DifferentialBranchFieldSpecification.php
···
47
47
}
48
48
49
49
public function didWriteRevision(DifferentialRevisionEditor $editor) {
50
+
$maniphest = 'PhabricatorApplicationManiphest';
51
+
if (!PhabricatorApplication::isClassInstalled($maniphest)) {
52
+
return;
53
+
}
54
+
50
55
$branch = $this->getDiff()->getBranch();
51
56
$match = null;
52
57
if (preg_match('/^T(\d+)/i', $branch, $match)) { // No $ to allow T123_demo.