recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make "Add Action..." add actions at the bottom instead of the top

Summary: Ref T9132. Shhh this never happened shhhhhhh.

Test Plan: Selected multiple actions, saw them add at the bottom.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9132

Differential Revision: https://secure.phabricator.com/D14664

epriestley 8bbea6d4 6bfb101a

+23 -16
+10 -10
resources/celerity/map.php
··· 427 427 'rsrc/js/application/repository/repository-crossreference.js' => 'e5339c43', 428 428 'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08', 429 429 'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f', 430 - 'rsrc/js/application/transactions/behavior-comment-actions.js' => 'f2c64202', 430 + 'rsrc/js/application/transactions/behavior-comment-actions.js' => 'dd5cae21', 431 431 'rsrc/js/application/transactions/behavior-reorder-fields.js' => 'b59e1e96', 432 432 'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'dbbf48b6', 433 433 'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => 'b23b49e6', ··· 571 571 'javelin-behavior-audit-preview' => 'd835b03a', 572 572 'javelin-behavior-bulk-job-reload' => 'edf8a145', 573 573 'javelin-behavior-choose-control' => '6153c708', 574 - 'javelin-behavior-comment-actions' => 'f2c64202', 574 + 'javelin-behavior-comment-actions' => 'dd5cae21', 575 575 'javelin-behavior-config-reorder-fields' => 'b6993408', 576 576 'javelin-behavior-conpherence-drag-and-drop-photo' => 'cf86d16a', 577 577 'javelin-behavior-conpherence-menu' => '1d45c74d', ··· 1867 1867 'javelin-dom', 1868 1868 'phabricator-busy', 1869 1869 ), 1870 + 'dd5cae21' => array( 1871 + 'javelin-behavior', 1872 + 'javelin-stratcom', 1873 + 'javelin-workflow', 1874 + 'javelin-dom', 1875 + 'phuix-form-control-view', 1876 + 'phuix-icon-view', 1877 + ), 1870 1878 'de2e896f' => array( 1871 1879 'javelin-behavior', 1872 1880 'javelin-dom', ··· 1967 1975 'javelin-util', 1968 1976 'javelin-workflow', 1969 1977 'javelin-json', 1970 - ), 1971 - 'f2c64202' => array( 1972 - 'javelin-behavior', 1973 - 'javelin-stratcom', 1974 - 'javelin-workflow', 1975 - 'javelin-dom', 1976 - 'phuix-form-control-view', 1977 - 'phuix-icon-view', 1978 1978 ), 1979 1979 'f36e01af' => array( 1980 1980 'javelin-behavior',
+11
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
··· 227 227 228 228 $action_id = celerity_generate_unique_node_id(); 229 229 $input_id = celerity_generate_unique_node_id(); 230 + $place_id = celerity_generate_unique_node_id(); 230 231 231 232 $form->appendChild( 232 233 phutil_tag( ··· 243 244 ->setID($action_id) 244 245 ->setOptions($options)); 245 246 247 + // This is an empty placeholder node so we know where to insert the 248 + // new actions. 249 + $form->appendChild( 250 + phutil_tag( 251 + 'div', 252 + array( 253 + 'id' => $place_id, 254 + ))); 255 + 246 256 Javelin::initBehavior( 247 257 'comment-actions', 248 258 array( 249 259 'actionID' => $action_id, 250 260 'inputID' => $input_id, 251 261 'formID' => $this->getFormID(), 262 + 'placeID' => $place_id, 252 263 'actions' => $action_map, 253 264 )); 254 265 }
+2 -6
webroot/rsrc/js/application/transactions/behavior-comment-actions.js
··· 14 14 var action_node = JX.$(config.actionID); 15 15 var form_node = JX.$(config.formID); 16 16 var input_node = JX.$(config.inputID); 17 + var place_node = JX.$(config.placeID); 17 18 18 19 var rows = {}; 19 20 ··· 73 74 option.disabled = false; 74 75 }); 75 76 76 - // TODO: Grotesque. 77 - action_node 78 - .parentNode 79 - .parentNode 80 - .parentNode 81 - .insertBefore(node, action_node.parentNode.parentNode.nextSibling); 77 + place_node.parentNode.insertBefore(node, place_node); 82 78 } 83 79 84 80 });