recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Destroy surplus columns

Summary:
Ref T1191. This destroys surplus columns:

- Pholio's transaction comments have a `mockID` column, but this is not used. The `imageID` column is used instead.
- Phragment has an unused `description` column.
- Releeph has an unused `summary` column.

Test Plan:
- Grepped for usage of these columns.
- Checked that these exist in production, too.
- Ran upgrades.
- Added Pholio inline comments.
- Saw fewer warnings.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, hach-que

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10591

epriestley 8bf24f53 943c62d1

+11 -2
+2
resources/sql/autopatches/20140927.schema.02.pholio1.sql
··· 1 + ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment 2 + DROP KEY `key_draft`;
+2
resources/sql/autopatches/20140927.schema.03.pholio2.sql
··· 1 + ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment 2 + ADD UNIQUE KEY `key_draft` (authorPHID, imageID, transactionPHID);
+2
resources/sql/autopatches/20140927.schema.04.pholio3.sql
··· 1 + ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment 2 + DROP COLUMN mockID;
+2
resources/sql/autopatches/20140927.schema.05.phragment1.sql
··· 1 + ALTER TABLE {$NAMESPACE}_phragment.phragment_snapshot 2 + DROP COLUMN description;
+2
resources/sql/autopatches/20140927.schema.06.releeph1.sql
··· 1 + ALTER TABLE {$NAMESPACE}_releeph.releeph_request 2 + DROP COLUMN summary;
+1 -2
src/applications/releeph/storage/ReleephRequest.php
··· 154 154 'userIntents' => self::SERIALIZATION_JSON, 155 155 ), 156 156 self::CONFIG_COLUMN_SCHEMA => array( 157 - 'summary' => 'text', 158 - 'requstCommitPHID' => 'phid?', 157 + 'requestCommitPHID' => 'phid?', 159 158 'commitIdentifier' => 'text40', 160 159 'pickStatus' => 'uint32', 161 160 'inBranch' => 'bool',