@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants
Summary:
The transaction types `TYPE_TITLE` and `TYPE_CONTENT` were removed from `PonderQuestionTransaction` in rPdff028c4907dd1959859733ea0d947f244559e7f.
Thus update `PonderQuestionCreateMailReceiver` to use the corresponding modular transactions `PonderQuestionTitleTransaction` and `PonderQuestionContentTransaction` instead.
Test Plan: Carefully read the code, grep the code base, use the test case in D25656#18162.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25656
+2
-2
+2
-2
src/applications/ponder/mail/PonderQuestionCreateMailReceiver.php
+2
-2
src/applications/ponder/mail/PonderQuestionCreateMailReceiver.php
···
20
20
$xactions = array();
21
21
22
22
$xactions[] = id(new PonderQuestionTransaction())
23
-
->setTransactionType(PonderQuestionTransaction::TYPE_TITLE)
23
+
->setTransactionType(PonderQuestionTitleTransaction::TRANSACTIONTYPE)
24
24
->setNewValue($title);
25
25
26
26
$xactions[] = id(new PonderQuestionTransaction())
27
-
->setTransactionType(PonderQuestionTransaction::TYPE_CONTENT)
27
+
->setTransactionType(PonderQuestionContentTransaction::TRANSACTIONTYPE)
28
28
->setNewValue($mail->getCleanTextBody());
29
29
30
30
$question = PonderQuestion::initializeNewQuestion($author);