recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make the buildables list a little nicer.

Summary:
Depends on D7501.

This just renders the buildable's actual object name onto the list, so you can see at a glance what the buildable represents. I'd like to also pull across a list of builds of this buildable and change the bar color, but I'm not quite sure how to do that in the search architecture without N+1 querying.

Test Plan:
Looked at the buildable list and it looked like this:

{F78555}

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D7502

authored by

James Rhodes and committed by
epriestley 8cae7f99 b6c88bd6

+2
+1
src/applications/harbormaster/controller/HarbormasterBuildableListController.php
··· 37 37 38 38 $item = id(new PHUIObjectItemView()) 39 39 ->setHeader(pht('Buildable %d', $buildable->getID())); 40 + $item->addAttribute($buildable->getBuildableHandle()->getFullName()); 40 41 41 42 if ($id) { 42 43 $item->setHref("/B{$id}");
+1
src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php
··· 11 11 12 12 public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) { 13 13 $query = id(new HarbormasterBuildableQuery()); 14 + $query->needBuildableHandles(true); 14 15 15 16 return $query; 16 17 }