@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix strlen(null) in DifferentialChangesetViewController loadCoverage()
Summary:
DifferentialChangesetViewController loadCoverage() fails under PHP 8.1 when test coverage is provided for some but not all modified files.
Update the code to replace strlen() with phutil_nonempty_string().
Fixes T15521
Test Plan: View a diff with test coverage for some but not all files.
Reviewers: O1 Blessed Committers, avivey
Reviewed By: O1 Blessed Committers, avivey
Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15521
Differential Revision: https://we.phorge.it/D25328
+2
-3
+2
-3
src/applications/differential/controller/DifferentialChangesetViewController.php
+2
-3
src/applications/differential/controller/DifferentialChangesetViewController.php
···
451
451
continue;
452
452
}
453
453
$coverage_data = idx($test_coverage, $changeset->getFileName());
454
-
if (!strlen($coverage_data)) {
455
-
continue;
454
+
if (phutil_nonempty_string($coverage_data)) {
455
+
$coverage[] = $coverage_data;
456
456
}
457
-
$coverage[] = $coverage_data;
458
457
}
459
458
460
459
if (!$coverage) {