@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When evaluating the "Branches" Herald field from the test console, use the current viewer
Summary: Ref T13093. Depends on D19145. See PHI398. Previously, see D18933. This provides the current viewer to `ConduitCall` so that we don't try to use device credentials from unprivileged web hosts.
Test Plan: Evaluated the "Branches" field locally, saw an appropriate field value.
Maniphest Tasks: T13093
Differential Revision: https://secure.phabricator.com/D19146
+3
-1
+3
-1
src/applications/diffusion/herald/DiffusionCommitBranchesHeraldField.php
+3
-1
src/applications/diffusion/herald/DiffusionCommitBranchesHeraldField.php
···
10
10
}
11
11
12
12
public function getHeraldFieldValue($object) {
13
+
$viewer = $this->getAdapter()->getViewer();
14
+
13
15
$commit = $object;
14
16
$repository = $object->getRepository();
15
17
···
19
21
);
20
22
21
23
$result = id(new ConduitCall('diffusion.branchquery', $params))
22
-
->setUser(PhabricatorUser::getOmnipotentUser())
24
+
->setUser($viewer)
23
25
->execute();
24
26
25
27
$refs = DiffusionRepositoryRef::loadAllFromDictionaries($result);