@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Provide missing default attachment list for Files transactions
Summary: Ref T13682. This property may not exist, and should defualt to an empty array if not present.
Test Plan: Created a new object.
Maniphest Tasks: T13682
Differential Revision: https://secure.phabricator.com/D21834
+1
-1
+1
-1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+1
-1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
2249
2249
foreach ($remarkup_changes as $remarkup_change) {
2250
2250
$metadata = $remarkup_change->getMetadata();
2251
2251
2252
-
$attached_phids = idx($metadata, 'attachedFilePHIDs');
2252
+
$attached_phids = idx($metadata, 'attachedFilePHIDs', array());
2253
2253
foreach ($attached_phids as $file_phid) {
2254
2254
$new_map[$file_phid] = PhabricatorFileAttachment::MODE_ATTACH;
2255
2255
}