recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow lint codes to be up to 128 bytes long

Summary:
Fixes T9145. We currently restrict lint codes to 32 bytes, but PHPCS generates codes like "PHPCS.E.PEAR.Comments.Messages.Line.TooLong".

These codes seem reasonable as codes, and we don't currently have any key-length problems or other technical concerns with simply raising the size of this column.

Test Plan: Ran `bin/storage upgrade` to pick up adjustments.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9145

Differential Revision: https://secure.phabricator.com/D14166

epriestley 8ce90a7c 284fe0fe

+1 -1
+1 -1
src/applications/harbormaster/storage/build/HarbormasterBuildLintMessage.php
··· 104 104 'path' => 'text', 105 105 'line' => 'uint32?', 106 106 'characterOffset' => 'uint32?', 107 - 'code' => 'text32', 107 + 'code' => 'text128', 108 108 'severity' => 'text32', 109 109 'name' => 'text255', 110 110 ),