@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a PhutilURI issue in workboards
Ref PHI1082.
+11
-3
+11
-3
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+11
-3
src/applications/project/controller/PhabricatorProjectBoardViewController.php
···
1182
1182
$project = $this->getProject();
1183
1183
1184
1184
if ($base === null) {
1185
-
$base = $this->getRequest()->getRequestURI();
1185
+
$base = $this->getRequest()->getPath();
1186
1186
}
1187
1187
1188
1188
$base = new PhutilURI($base);
1189
1189
1190
1190
if ($force || ($this->sortKey != $this->getDefaultSort($project))) {
1191
-
$base->replaceQueryParam('order', $this->sortKey);
1191
+
if ($this->sortKey !== null) {
1192
+
$base->replaceQueryParam('order', $this->sortKey);
1193
+
} else {
1194
+
$base->removeQueryParam('order');
1195
+
}
1192
1196
} else {
1193
1197
$base->removeQueryParam('order');
1194
1198
}
1195
1199
1196
1200
if ($force || ($this->queryKey != $this->getDefaultFilter($project))) {
1197
-
$base->replaceQueryParam('filter', $this->queryKey);
1201
+
if ($this->queryKey !== null) {
1202
+
$base->replaceQueryParam('filter', $this->queryKey);
1203
+
} else {
1204
+
$base->removeQueryParam('filter');
1205
+
}
1198
1206
} else {
1199
1207
$base->removeQueryParam('filter');
1200
1208
}