@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix several pieces of UI language describing "draft/archive" rules in Phame
Summary: Ref T12900. We implement one rule, but tell users a different (older) rule. See T12900 for discussion and history.
Test Plan:
- Verified draft/archived posts can't be seen by users who don't have permission to edit the blog.
- Drafted, archived, and published posts and read the related text.
- Looked through the changes I dug up in T12900#228748 for other strings I might have missed.
{F5033860}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12900
Differential Revision: https://secure.phabricator.com/D18182
+14
-8
+3
-2
src/applications/phame/controller/post/PhamePostArchiveController.php
+3
-2
src/applications/phame/controller/post/PhamePostArchiveController.php
···
42
42
43
43
$title = pht('Archive Post');
44
44
$body = pht(
45
-
'This post will revert to archived status and no longer be visible '.
46
-
'to other users or members of this blog.');
45
+
'If you archive this post, it will only be visible to users who can '.
46
+
'edit %s.',
47
+
$viewer->renderHandle($post->getBlogPHID()));
47
48
$button = pht('Archive Post');
48
49
49
50
return $this->newDialog()
+8
-4
src/applications/phame/controller/post/PhamePostViewController.php
+8
-4
src/applications/phame/controller/post/PhamePostViewController.php
···
46
46
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
47
47
->setTitle(pht('Draft Post'))
48
48
->appendChild(
49
-
pht('Only you can see this draft until you publish it. '.
50
-
'Use "Publish" to publish this post.')));
49
+
pht(
50
+
'This is a draft, and is only visible to you and other users '.
51
+
'who can edit %s. Use "Publish" to publish this post.',
52
+
$viewer->renderHandle($post->getBlogPHID()))));
51
53
}
52
54
53
55
if ($post->isArchived()) {
···
56
58
->setSeverity(PHUIInfoView::SEVERITY_ERROR)
57
59
->setTitle(pht('Archived Post'))
58
60
->appendChild(
59
-
pht('Only you can see this archived post until you publish it. '.
60
-
'Use "Publish" to publish this post.')));
61
+
pht(
62
+
'This post has been archived, and is only visible to you and '.
63
+
'other users who can edit %s.',
64
+
$viewer->renderHandle($post->getBlogPHID()))));
61
65
}
62
66
63
67
if (!$post->getBlog()) {
+3
-2
src/applications/phame/storage/PhamePost.php
+3
-2
src/applications/phame/storage/PhamePost.php
···
200
200
}
201
201
202
202
public function getPolicy($capability) {
203
-
// Draft posts are visible only to the author. Published posts are visible
204
-
// to whoever the blog is visible to.
203
+
// Draft and archived posts are visible only to the author and other
204
+
// users who can edit the blog. Published posts are visible to whoever
205
+
// the blog is visible to.
205
206
206
207
switch ($capability) {
207
208
case PhabricatorPolicyCapability::CAN_VIEW: