@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Maniphest links w.r.t. new "status" data format
Summary: 0 => imploded string of hotness. Fixes T4689
Test Plan: for each spot i fixed, clicked link and it worked! (I did a grep for "/maniphest" to find these spots; 98% confident I got them all.)
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T4689
Differential Revision: https://secure.phabricator.com/D8626
+17
-8
+9
-3
src/applications/home/controller/PhabricatorHomeMainController.php
+9
-3
src/applications/home/controller/PhabricatorHomeMainController.php
···
148
148
'Nothing appears to be critically broken right now.');
149
149
}
150
150
151
-
$href = '/maniphest/?statuses[]=0&priorities[]='.$unbreak_now.'#R';
151
+
$href = sprintf(
152
+
'/maniphest/?statuses[]=%s&priorities[]=%s#R',
153
+
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
154
+
$unbreak_now);
152
155
$title = pht('Unbreak Now!');
153
156
$panel = new AphrontPanelView();
154
157
$panel->setHeader($this->renderSectionHeader($title, $href));
···
193
196
}
194
197
195
198
$title = pht('Needs Triage');
196
-
$href = '/maniphest/?statuses[]=0&priorities[]='.$needs_triage.
197
-
'&userProjects[]='.$user->getPHID().'#R';
199
+
$href = sprintf(
200
+
'/maniphest/?statuses[]=%s&priorities[]=%s&userProjects[]=%s#R',
201
+
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
202
+
$needs_triage,
203
+
$user->getPHID());
198
204
$panel = new AphrontPanelView();
199
205
$panel->setHeader($this->renderSectionHeader($title, $href));
200
206
$panel->appendChild($this->buildTaskListView($tasks));
-3
src/applications/maniphest/controller/ManiphestReportController.php
-3
src/applications/maniphest/controller/ManiphestReportController.php
+4
-1
src/applications/maniphest/event/ManiphestActionMenuEventListener.php
+4
-1
src/applications/maniphest/event/ManiphestActionMenuEventListener.php
···
32
32
33
33
$user = $event->getValue('object');
34
34
$phid = $user->getPHID();
35
-
$view_uri = '/maniphest/?statuses[]=0&assigned='.$phid.'#R';
35
+
$view_uri = sprintf(
36
+
'/maniphest/?statuses[]=%s&assigned=%s#R',
37
+
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
38
+
$phid);
36
39
37
40
return id(new PhabricatorActionView())
38
41
->setIcon('maniphest-dark')
+4
-1
src/applications/project/controller/PhabricatorProjectProfileController.php
+4
-1
src/applications/project/controller/PhabricatorProjectProfileController.php
···
147
147
$task_list->setHandles($handles);
148
148
149
149
$phid = $project->getPHID();
150
-
$view_uri = '/maniphest/?statuses[]=0&allProjects[]='.$phid.'#R';
150
+
$view_uri = sprintf(
151
+
'/maniphest/?statuses[]=%s&allProjects[]=%s#R',
152
+
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
153
+
$phid);
151
154
$create_uri = '/maniphest/task/create/?projects='.$phid;
152
155
$icon = id(new PHUIIconView())
153
156
->setSpriteSheet(PHUIIconView::SPRITE_ICONS)