@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Macros - fix audio disabling not actually disabling audio
Summary: Fixes T5653.
Test Plan: made a macro with sound and it played. changed it to not play and it did not play. changed it back and it played once more.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T5653
Differential Revision: https://secure.phabricator.com/D10085
+3
-1
+3
-1
src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
+3
-1
src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
···
124
124
125
125
$id = null;
126
126
$audio = idx($files, $macro->getAudioPHID());
127
-
if ($audio) {
127
+
$should_play = ($audio && $macro->getAudioBehavior() !=
128
+
PhabricatorFileImageMacro::AUDIO_BEHAVIOR_NONE);
129
+
if ($should_play) {
128
130
$id = celerity_generate_unique_node_id();
129
131
130
132
$loop = null;