@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove AphrontPanelView
Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it.
Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7427
Differential Revision: https://secure.phabricator.com/D12004
+9
-232
+9
-9
resources/celerity/map.php
+9
-9
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'a9770fbb',
10
+
'core.pkg.css' => '6408f2d3',
11
11
'core.pkg.js' => '5a1c336d',
12
12
'darkconsole.pkg.js' => '8ab24e01',
13
13
'differential.pkg.css' => '6641cdd5',
···
24
24
'rsrc/css/aphront/multi-column.css' => '41a848c0',
25
25
'rsrc/css/aphront/notification.css' => '9c279160',
26
26
'rsrc/css/aphront/pager-view.css' => '2e3539af',
27
-
'rsrc/css/aphront/panel-view.css' => '7e0c3a56',
27
+
'rsrc/css/aphront/panel-view.css' => '8427b78d',
28
28
'rsrc/css/aphront/phabricator-nav-view.css' => '7aeaf435',
29
29
'rsrc/css/aphront/table-view.css' => 'b22b7216',
30
30
'rsrc/css/aphront/tokenizer.css' => '82ce2142',
···
72
72
'rsrc/css/application/herald/herald.css' => '826075fa',
73
73
'rsrc/css/application/home/home.css' => 'e34bf140',
74
74
'rsrc/css/application/maniphest/batch-editor.css' => '8f380ebc',
75
-
'rsrc/css/application/maniphest/report.css' => 'd8ed71ad',
75
+
'rsrc/css/application/maniphest/report.css' => 'f6931fdf',
76
76
'rsrc/css/application/maniphest/task-edit.css' => '8e23031b',
77
77
'rsrc/css/application/maniphest/task-summary.css' => 'ab2fc691',
78
78
'rsrc/css/application/objectselector/object-selector.css' => '029a133d',
···
129
129
'rsrc/css/phui/phui-document.css' => '0f83a7df',
130
130
'rsrc/css/phui/phui-feed-story.css' => 'c9f3a0b5',
131
131
'rsrc/css/phui/phui-fontkit.css' => 'd30f4fa3',
132
-
'rsrc/css/phui/phui-form-view.css' => '76f0b086',
132
+
'rsrc/css/phui/phui-form-view.css' => '78d729fe',
133
133
'rsrc/css/phui/phui-form.css' => 'f535f938',
134
134
'rsrc/css/phui/phui-header-view.css' => '083669db',
135
135
'rsrc/css/phui/phui-icon.css' => 'd35aa857',
136
136
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
137
137
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
138
-
'rsrc/css/phui/phui-info-view.css' => '6c6cc4dd',
138
+
'rsrc/css/phui/phui-info-view.css' => 'c6f0aef8',
139
139
'rsrc/css/phui/phui-list.css' => '53deb25c',
140
140
'rsrc/css/phui/phui-object-box.css' => 'd68ce5dc',
141
141
'rsrc/css/phui/phui-object-item-list-view.css' => '9db65899',
···
502
502
'aphront-list-filter-view-css' => '2ae43867',
503
503
'aphront-multi-column-view-css' => '41a848c0',
504
504
'aphront-pager-view-css' => '2e3539af',
505
-
'aphront-panel-view-css' => '7e0c3a56',
505
+
'aphront-panel-view-css' => '8427b78d',
506
506
'aphront-table-view-css' => 'b22b7216',
507
507
'aphront-tokenizer-control-css' => '82ce2142',
508
508
'aphront-tooltip-css' => '4099b97e',
···
698
698
'javelin-workflow' => '84d6aea0',
699
699
'lightbox-attachment-css' => '7acac05d',
700
700
'maniphest-batch-editor' => '8f380ebc',
701
-
'maniphest-report-css' => 'd8ed71ad',
701
+
'maniphest-report-css' => 'f6931fdf',
702
702
'maniphest-task-edit-css' => '8e23031b',
703
703
'maniphest-task-summary-css' => 'ab2fc691',
704
704
'multirow-row-manager' => 'b5d57730',
···
781
781
'phui-font-icon-base-css' => '3dad2ae3',
782
782
'phui-fontkit-css' => 'd30f4fa3',
783
783
'phui-form-css' => 'f535f938',
784
-
'phui-form-view-css' => '76f0b086',
784
+
'phui-form-view-css' => '78d729fe',
785
785
'phui-header-view-css' => '083669db',
786
786
'phui-icon-view-css' => 'd35aa857',
787
787
'phui-image-mask-css' => '5a8b09c8',
788
788
'phui-info-panel-css' => '27ea50a1',
789
-
'phui-info-view-css' => '6c6cc4dd',
789
+
'phui-info-view-css' => 'c6f0aef8',
790
790
'phui-list-view-css' => '53deb25c',
791
791
'phui-object-box-css' => 'd68ce5dc',
792
792
'phui-object-item-list-view-css' => '9db65899',
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
151
151
'AphrontPHPHTTPSink' => 'aphront/sink/AphrontPHPHTTPSink.php',
152
152
'AphrontPageView' => 'view/page/AphrontPageView.php',
153
153
'AphrontPagerView' => 'view/control/AphrontPagerView.php',
154
-
'AphrontPanelView' => 'view/layout/AphrontPanelView.php',
155
154
'AphrontPlainTextResponse' => 'aphront/response/AphrontPlainTextResponse.php',
156
155
'AphrontProgressBarView' => 'view/widget/bars/AphrontProgressBarView.php',
157
156
'AphrontProxyResponse' => 'aphront/response/AphrontProxyResponse.php',
···
3307
3306
'AphrontPHPHTTPSink' => 'AphrontHTTPSink',
3308
3307
'AphrontPageView' => 'AphrontView',
3309
3308
'AphrontPagerView' => 'AphrontView',
3310
-
'AphrontPanelView' => 'AphrontView',
3311
3309
'AphrontPlainTextResponse' => 'AphrontResponse',
3312
3310
'AphrontProgressBarView' => 'AphrontBarView',
3313
3311
'AphrontProxyResponse' => 'AphrontResponse',
-106
src/view/layout/AphrontPanelView.php
-106
src/view/layout/AphrontPanelView.php
···
1
-
<?php
2
-
3
-
final class AphrontPanelView extends AphrontView {
4
-
5
-
const WIDTH_FULL = 'full';
6
-
const WIDTH_FORM = 'form';
7
-
const WIDTH_WIDE = 'wide';
8
-
9
-
private $buttons = array();
10
-
private $header;
11
-
private $caption;
12
-
private $width;
13
-
private $classes = array();
14
-
private $id;
15
-
16
-
public function setCreateButton($create_button, $href) {
17
-
$this->addButton(
18
-
phutil_tag(
19
-
'a',
20
-
array(
21
-
'href' => $href,
22
-
'class' => 'button green',
23
-
),
24
-
$create_button));
25
-
26
-
return $this;
27
-
}
28
-
29
-
public function addClass($class) {
30
-
$this->classes[] = $class;
31
-
return $this;
32
-
}
33
-
34
-
public function addButton($button) {
35
-
$this->buttons[] = $button;
36
-
return $this;
37
-
}
38
-
39
-
public function setHeader($header) {
40
-
$this->header = $header;
41
-
return $this;
42
-
}
43
-
44
-
public function setWidth($width) {
45
-
$this->width = $width;
46
-
return $this;
47
-
}
48
-
49
-
public function setID($id) {
50
-
$this->id = $id;
51
-
return $this;
52
-
}
53
-
54
-
public function setCaption($caption) {
55
-
$this->caption = $caption;
56
-
return $this;
57
-
}
58
-
59
-
public function setNoBackground() {
60
-
$this->classes[] = 'aphront-panel-plain';
61
-
return $this;
62
-
}
63
-
64
-
public function render() {
65
-
if ($this->header !== null) {
66
-
$header = phutil_tag('h1', array(), $this->header);
67
-
} else {
68
-
$header = null;
69
-
}
70
-
71
-
if ($this->caption !== null) {
72
-
$caption = phutil_tag_div('aphront-panel-view-caption', $this->caption);
73
-
} else {
74
-
$caption = null;
75
-
}
76
-
77
-
$buttons = null;
78
-
if ($this->buttons) {
79
-
$buttons = phutil_tag_div(
80
-
'aphront-panel-view-buttons',
81
-
phutil_implode_html(' ', $this->buttons));
82
-
}
83
-
$header_elements = phutil_tag_div(
84
-
'aphront-panel-header',
85
-
array($buttons, $header, $caption));
86
-
87
-
$table = phutil_implode_html('', $this->renderChildren());
88
-
89
-
require_celerity_resource('aphront-panel-view-css');
90
-
91
-
$classes = $this->classes;
92
-
$classes[] = 'aphront-panel-view';
93
-
if ($this->width) {
94
-
$classes[] = 'aphront-panel-width-'.$this->width;
95
-
}
96
-
97
-
return phutil_tag(
98
-
'div',
99
-
array(
100
-
'class' => implode(' ', $classes),
101
-
'id' => $this->id,
102
-
),
103
-
array($header_elements, $table));
104
-
}
105
-
106
-
}
-101
webroot/rsrc/css/aphront/panel-view.css
-101
webroot/rsrc/css/aphront/panel-view.css
···
2
2
* @provides aphront-panel-view-css
3
3
*/
4
4
5
-
6
-
.aphront-panel-view {
7
-
background: {$lightgreybackground};
8
-
border: 1px solid #c0c0c0;
9
-
border-width: 1px 0 0;
10
-
padding: 8px 16px;
11
-
margin: 20px 16px 32px 16px;
12
-
}
13
-
14
-
.device-phone .aphront-panel-view {
15
-
margin: 20px 8px 40px 8px;
16
-
}
17
-
18
-
.aphront-unpadded-panel-view {
19
-
padding: 0;
20
-
}
21
-
22
-
.aphront-panel-view.aphront-panel-plain {
23
-
padding: 0;
24
-
border: none;
25
-
background: transparent;
26
-
}
27
-
28
-
.aphront-panel-view .aphront-panel-header {
29
-
margin: 0 0 8px 0;
30
-
}
31
-
32
-
.aphront-panel-view h1 {
33
-
font-size: 16px;
34
-
font-weight: bold;
35
-
color: {$darkbluetext};
36
-
text-shadow: 0 1px 1px #fff;
37
-
padding: 4px 0 0 0;
38
-
}
39
-
40
-
.aphront-panel-view h1 a {
41
-
color: {$darkbluetext};
42
-
text-decoration: none;
43
-
}
44
-
45
-
.aphront-panel-view h1 a:hover {
46
-
text-decoration: underline;
47
-
}
48
-
49
-
.aphront-panel-plain h1 {
50
-
padding: 0;
51
-
}
52
-
53
-
.aphront-panel-view-caption {
54
-
font-size: 11px;
55
-
color: {$greytext};
56
-
margin-top: 4px;
57
-
margin-bottom: 4px;
58
-
}
59
-
60
-
.aphront-panel-view-buttons {
61
-
float: right;
62
-
}
63
-
64
-
.device-desktop .aphront-panel-width-form {
65
-
width: 720px;
66
-
margin-right: auto;
67
-
margin-left: auto;
68
-
}
69
-
70
-
.device-desktop .aphront-panel-width-wide {
71
-
width: 1080px;
72
-
margin-right: auto;
73
-
margin-left: auto;
74
-
}
75
-
76
-
.aphront-panel-accent {
77
-
background: #f1f1f1;
78
-
border: 1px solid #ddd;
79
-
border-radius: 3px;
80
-
}
81
-
82
-
.aphront-panel-accent .phui-form-view {
83
-
background: {$lightgreybackground};
84
-
border: 1px solid #c4c4c0;
85
-
border-radius: 3px;
86
-
}
87
-
88
5
.aphront-panel-preview {
89
6
padding: 16px;
90
7
}
···
93
10
display: none;
94
11
}
95
12
96
-
.aphront-panel-preview-wide {
97
-
width: 1080px;
98
-
margin-left: auto;
99
-
margin-right: auto;
100
-
padding-left: 2em;
101
-
padding-right: 2em;
102
-
}
103
-
104
13
.aphront-panel-preview-loading-text {
105
14
color: {$greytext};
106
15
}
···
108
17
.aphront-panel-flush {
109
18
margin: 0;
110
19
}
111
-
112
-
.aphront-panel-view-drag-and-drop {
113
-
background: #99ff99;
114
-
border-color: #669966;
115
-
}
116
-
117
-
.aphront-panel-view-drag-and-drop .phui-form-view {
118
-
background: #ccffcc;
119
-
border-color: #669966;
120
-
}
-4
webroot/rsrc/css/application/maniphest/report.css
-4
webroot/rsrc/css/application/maniphest/report.css
-5
webroot/rsrc/css/phui/phui-form-view.css
-5
webroot/rsrc/css/phui/phui-form-view.css