@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix two overzealous renames of getPanelKey()
Summary: Fixes T11999. These are actual panels (SettingsPanel) which are panelley so it's OK.
Test Plan: Clicked "Customize Menu..." on Home.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11999
Differential Revision: https://secure.phabricator.com/D17032
+2
-2
+2
-2
src/applications/settings/controller/PhabricatorSettingsMainController.php
+2
-2
src/applications/settings/controller/PhabricatorSettingsMainController.php
···
98
98
$panels = $this->buildPanels($preferences);
99
99
$nav = $this->renderSideNav($panels);
100
100
101
-
$key = $nav->selectFilter($key, head($panels)->getMenuItemKey());
101
+
$key = $nav->selectFilter($key, head($panels)->getPanelKey());
102
102
103
103
$panel = $panels[$key]
104
104
->setController($this)
···
196
196
$nav->addLabel($group->getPanelGroupName());
197
197
}
198
198
199
-
$nav->addFilter($panel->getMenuItemKey(), $panel->getPanelName());
199
+
$nav->addFilter($panel->getPanelKey(), $panel->getPanelName());
200
200
}
201
201
202
202
return $nav;