recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"

Summary: Ref T13682. Many subclasses of "CursorPagedPolicyAwareQuery" have the same implementation of "loadPage()", and this is a sensible default behavior.

Test Plan: Examined changes to verify that all removed methods have the same behavior.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13682

Differential Revision: https://secure.phabricator.com/D21838

epriestley 8e703c8c 5493f028

+20 -442
-4
src/applications/almanac/query/AlmanacBindingQuery.php
··· 44 44 return new AlmanacBinding(); 45 45 } 46 46 47 - protected function loadPage() { 48 - return $this->loadStandardPage($this->newResultObject()); 49 - } 50 - 51 47 protected function willFilterPage(array $bindings) { 52 48 $service_phids = mpull($bindings, 'getServicePHID'); 53 49 $device_phids = mpull($bindings, 'getDevicePHID');
-4
src/applications/almanac/query/AlmanacDeviceQuery.php
··· 56 56 return new AlmanacDevice(); 57 57 } 58 58 59 - protected function loadPage() { 60 - return $this->loadStandardPage($this->newResultObject()); 61 - } 62 - 63 59 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 64 60 $where = parent::buildWhereClauseParts($conn); 65 61
-4
src/applications/almanac/query/AlmanacInterfaceQuery.php
··· 38 38 return new AlmanacInterface(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function willFilterPage(array $interfaces) { 46 42 $network_phids = mpull($interfaces, 'getNetworkPHID'); 47 43 $device_phids = mpull($interfaces, 'getDevicePHID');
-4
src/applications/almanac/query/AlmanacNamespaceQuery.php
··· 32 32 return new AlmanacNamespace(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/almanac/query/AlmanacNetworkQuery.php
··· 32 32 $ngrams); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/almanac/query/AlmanacPropertyQuery.php
··· 33 33 return new AlmanacProperty(); 34 34 } 35 35 36 - protected function loadPage() { 37 - return $this->loadStandardPage($this->newResultObject()); 38 - } 39 - 40 36 protected function willFilterPage(array $properties) { 41 37 $object_phids = mpull($properties, 'getObjectPHID'); 42 38
-4
src/applications/almanac/query/AlmanacServiceQuery.php
··· 69 69 return new AlmanacService(); 70 70 } 71 71 72 - protected function loadPage() { 73 - return $this->loadStandardPage($this->newResultObject()); 74 - } 75 - 76 72 protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) { 77 73 $joins = parent::buildJoinClauseParts($conn); 78 74
-4
src/applications/auth/query/PhabricatorAuthChallengeQuery.php
··· 40 40 return new PhabricatorAuthChallenge(); 41 41 } 42 42 43 - protected function loadPage() { 44 - return $this->loadStandardPage($this->newResultObject()); 45 - } 46 - 47 43 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 48 44 $where = parent::buildWhereClauseParts($conn); 49 45
-4
src/applications/auth/query/PhabricatorAuthContactNumberQuery.php
··· 44 44 return new PhabricatorAuthContactNumber(); 45 45 } 46 46 47 - protected function loadPage() { 48 - return $this->loadStandardPage($this->newResultObject()); 49 - } 50 - 51 47 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 52 48 $where = parent::buildWhereClauseParts($conn); 53 49
-4
src/applications/auth/query/PhabricatorAuthFactorConfigQuery.php
··· 38 38 return new PhabricatorAuthFactorConfig(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 46 42 $where = parent::buildWhereClauseParts($conn); 47 43
-4
src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php
··· 32 32 return new PhabricatorAuthFactorProvider(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/auth/query/PhabricatorAuthMessageQuery.php
··· 26 26 return new PhabricatorAuthMessage(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/auth/query/PhabricatorAuthPasswordQuery.php
··· 38 38 return new PhabricatorAuthPassword(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 46 42 $where = parent::buildWhereClauseParts($conn); 47 43
-4
src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php
··· 32 32 return new PhabricatorAuthProviderConfig(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php
··· 47 47 return new PhabricatorAuthSSHKey(); 48 48 } 49 49 50 - protected function loadPage() { 51 - return $this->loadStandardPage($this->newResultObject()); 52 - } 53 - 54 50 protected function willFilterPage(array $keys) { 55 51 $object_phids = mpull($keys, 'getObjectPHID'); 56 52
-4
src/applications/auth/query/PhabricatorAuthSessionQuery.php
··· 38 38 return new PhabricatorAuthSession(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function willFilterPage(array $sessions) { 46 42 $identity_phids = mpull($sessions, 'getUserPHID'); 47 43
-4
src/applications/auth/query/PhabricatorAuthTemporaryTokenQuery.php
··· 44 44 return new PhabricatorAuthTemporaryToken(); 45 45 } 46 46 47 - protected function loadPage() { 48 - return $this->loadStandardPage($this->newResultObject()); 49 - } 50 - 51 47 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 52 48 $where = parent::buildWhereClauseParts($conn); 53 49
-4
src/applications/auth/query/PhabricatorExternalAccountIdentifierQuery.php
··· 38 38 return new PhabricatorExternalAccountIdentifier(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 46 42 $where = parent::buildWhereClauseParts($conn); 47 43
-4
src/applications/auth/query/PhabricatorExternalAccountQuery.php
··· 66 66 return new PhabricatorExternalAccount(); 67 67 } 68 68 69 - protected function loadPage() { 70 - return $this->loadStandardPage($this->newResultObject()); 71 - } 72 - 73 69 protected function willFilterPage(array $accounts) { 74 70 $viewer = $this->getViewer(); 75 71
-4
src/applications/badges/query/PhabricatorBadgesAwardQuery.php
··· 57 57 return (bool)$this->badgeStatuses; 58 58 } 59 59 60 - protected function loadPage() { 61 - return $this->loadStandardPage($this->newResultObject()); 62 - } 63 - 64 60 public function newResultObject() { 65 61 return new PhabricatorBadgesAward(); 66 62 }
-4
src/applications/badges/query/PhabricatorBadgesQuery.php
··· 34 34 $ngrams); 35 35 } 36 36 37 - protected function loadPage() { 38 - return $this->loadStandardPage($this->newResultObject()); 39 - } 40 - 41 37 protected function getPrimaryTableAlias() { 42 38 return 'badges'; 43 39 }
-4
src/applications/calendar/query/PhabricatorCalendarExportQuery.php
··· 38 38 return new PhabricatorCalendarExport(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 46 42 $where = parent::buildWhereClauseParts($conn); 47 43
-4
src/applications/calendar/query/PhabricatorCalendarExternalInviteeQuery.php
··· 26 26 return new PhabricatorCalendarExternalInvitee(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/calendar/query/PhabricatorCalendarImportLogQuery.php
··· 26 26 return new PhabricatorCalendarImportLog(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/calendar/query/PhabricatorCalendarImportQuery.php
··· 32 32 return new PhabricatorCalendarImport(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/conduit/query/PhabricatorConduitLogQuery.php
··· 40 40 return new PhabricatorConduitMethodCallLog(); 41 41 } 42 42 43 - protected function loadPage() { 44 - return $this->loadStandardPage($this->newResultObject()); 45 - } 46 - 47 43 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 48 44 $where = parent::buildWhereClauseParts($conn); 49 45
-4
src/applications/conduit/query/PhabricatorConduitTokenQuery.php
··· 38 38 return new PhabricatorConduitToken(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 46 42 $where = parent::buildWhereClauseParts($conn); 47 43
-4
src/applications/countdown/query/PhabricatorCountdownQuery.php
··· 28 28 return $this; 29 29 } 30 30 31 - protected function loadPage() { 32 - return $this->loadStandardPage($this->newResultObject()); 33 - } 34 - 35 31 public function newResultObject() { 36 32 return new PhabricatorCountdown(); 37 33 }
-4
src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php
··· 34 34 return $this; 35 35 } 36 36 37 - protected function loadPage() { 38 - return $this->loadStandardPage($this->newResultObject()); 39 - } 40 - 41 37 public function newResultObject() { 42 38 // TODO: If we don't do this, SearchEngine explodes when trying to 43 39 // enumerate custom fields. For now, just give the panel a default panel
-4
src/applications/dashboard/query/PhabricatorDashboardPortalQuery.php
··· 26 26 return new PhabricatorDashboardPortal(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/dashboard/query/PhabricatorDashboardQuery.php
··· 34 34 return $this; 35 35 } 36 36 37 - protected function loadPage() { 38 - return $this->loadStandardPage($this->newResultObject()); 39 - } 40 - 41 37 public function newResultObject() { 42 38 return new PhabricatorDashboard(); 43 39 }
-4
src/applications/differential/query/DifferentialChangesetQuery.php
··· 58 58 return new DifferentialChangeset(); 59 59 } 60 60 61 - protected function loadPage() { 62 - return $this->loadStandardPage($this->newResultObject()); 63 - } 64 - 65 61 protected function willFilterPage(array $changesets) { 66 62 // First, attach all the diffs we already have. We can just do this 67 63 // directly without worrying about querying for them. When we don't have
-4
src/applications/differential/query/DifferentialDiffQuery.php
··· 57 57 return new DifferentialDiff(); 58 58 } 59 59 60 - protected function loadPage() { 61 - return $this->loadStandardPage($this->newResultObject()); 62 - } 63 - 64 60 protected function willFilterPage(array $diffs) { 65 61 $revision_ids = array_filter(mpull($diffs, 'getRevisionID')); 66 62
-4
src/applications/differential/query/DifferentialHunkQuery.php
··· 34 34 return new DifferentialHunk(); 35 35 } 36 36 37 - protected function loadPage() { 38 - return $this->loadStandardPage($this->newResultObject()); 39 - } 40 - 41 37 protected function willFilterPage(array $hunks) { 42 38 $changesets = mpull($this->changesets, null, 'getID'); 43 39 foreach ($hunks as $key => $hunk) {
-4
src/applications/differential/query/DifferentialViewStateQuery.php
··· 26 26 return new DifferentialViewState(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/diffusion/query/DiffusionCommitHintQuery.php
··· 56 56 $this->commitMap = array(); 57 57 } 58 58 59 - protected function loadPage() { 60 - return $this->loadStandardPage($this->newResultObject()); 61 - } 62 - 63 59 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 64 60 $where = parent::buildWhereClauseParts($conn); 65 61
-4
src/applications/doorkeeper/query/DoorkeeperExternalObjectQuery.php
··· 20 20 return new DoorkeeperExternalObject(); 21 21 } 22 22 23 - protected function loadPage() { 24 - return $this->loadStandardPage($this->newResultObject()); 25 - } 26 - 27 23 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 28 24 $where = parent::buildWhereClauseParts($conn); 29 25
-4
src/applications/drydock/query/DrydockAuthorizationQuery.php
··· 72 72 return new DrydockAuthorization(); 73 73 } 74 74 75 - protected function loadPage() { 76 - return $this->loadStandardPage($this->newResultObject()); 77 - } 78 - 79 75 protected function willFilterPage(array $authorizations) { 80 76 $blueprint_phids = mpull($authorizations, 'getBlueprintPHID'); 81 77 if ($blueprint_phids) {
-4
src/applications/drydock/query/DrydockBlueprintQuery.php
··· 95 95 return 'blueprint'; 96 96 } 97 97 98 - protected function loadPage() { 99 - return $this->loadStandardPage($this->newResultObject()); 100 - } 101 - 102 98 protected function willExecute() { 103 99 if ($this->identifiers) { 104 100 $this->identifierMap = array();
-4
src/applications/drydock/query/DrydockCommandQuery.php
··· 25 25 return new DrydockCommand(); 26 26 } 27 27 28 - protected function loadPage() { 29 - return $this->loadStandardPage($this->newResultObject()); 30 - } 31 - 32 28 protected function willFilterPage(array $commands) { 33 29 $target_phids = mpull($commands, 'getTargetPHID'); 34 30
-4
src/applications/drydock/query/DrydockLeaseQuery.php
··· 57 57 return new DrydockLease(); 58 58 } 59 59 60 - protected function loadPage() { 61 - return $this->loadStandardPage($this->newResultObject()); 62 - } 63 - 64 60 protected function willFilterPage(array $leases) { 65 61 $resource_phids = array_filter(mpull($leases, 'getResourcePHID')); 66 62 if ($resource_phids) {
-4
src/applications/drydock/query/DrydockLogQuery.php
··· 37 37 return new DrydockLog(); 38 38 } 39 39 40 - protected function loadPage() { 41 - return $this->loadStandardPage($this->newResultObject()); 42 - } 43 - 44 40 protected function didFilterPage(array $logs) { 45 41 $blueprint_phids = array_filter(mpull($logs, 'getBlueprintPHID')); 46 42 if ($blueprint_phids) {
-4
src/applications/drydock/query/DrydockRepositoryOperationQuery.php
··· 55 55 return new DrydockRepositoryOperation(); 56 56 } 57 57 58 - protected function loadPage() { 59 - return $this->loadStandardPage($this->newResultObject()); 60 - } 61 - 62 58 protected function willFilterPage(array $operations) { 63 59 $implementations = DrydockRepositoryOperationType::getAllOperationTypes(); 64 60
-4
src/applications/drydock/query/DrydockResourceQuery.php
··· 49 49 return new DrydockResource(); 50 50 } 51 51 52 - protected function loadPage() { 53 - return $this->loadStandardPage($this->newResultObject()); 54 - } 55 - 56 52 protected function willFilterPage(array $resources) { 57 53 $blueprint_phids = mpull($resources, 'getBlueprintPHID'); 58 54
-4
src/applications/files/query/PhabricatorFileAttachmentQuery.php
··· 32 32 return new PhabricatorFileAttachment(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/fund/query/FundInitiativeQuery.php
··· 32 32 return new FundInitiative(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/harbormaster/query/HarbormasterBuildArtifactQuery.php
··· 40 40 return new HarbormasterBuildArtifact(); 41 41 } 42 42 43 - protected function loadPage() { 44 - return $this->loadStandardPage($this->newResultObject()); 45 - } 46 - 47 43 protected function willFilterPage(array $page) { 48 44 $build_targets = array(); 49 45
-4
src/applications/harbormaster/query/HarbormasterBuildLogQuery.php
··· 27 27 return new HarbormasterBuildLog(); 28 28 } 29 29 30 - protected function loadPage() { 31 - return $this->loadStandardPage($this->newResultObject()); 32 - } 33 - 34 30 protected function willFilterPage(array $page) { 35 31 $build_targets = array(); 36 32
-4
src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php
··· 26 26 return new HarbormasterBuildMessage(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function willFilterPage(array $page) { 34 30 $receiver_phids = array_filter(mpull($page, 'getReceiverPHID')); 35 31 if ($receiver_phids) {
-4
src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php
··· 50 50 return new HarbormasterBuildPlan(); 51 51 } 52 52 53 - protected function loadPage() { 54 - return $this->loadStandardPage($this->newResultObject()); 55 - } 56 - 57 53 protected function didFilterPage(array $page) { 58 54 if ($this->needBuildSteps) { 59 55 $plan_phids = mpull($page, 'getPHID');
-4
src/applications/harbormaster/query/HarbormasterBuildQuery.php
··· 56 56 return new HarbormasterBuild(); 57 57 } 58 58 59 - protected function loadPage() { 60 - return $this->loadStandardPage($this->newResultObject()); 61 - } 62 - 63 59 protected function willFilterPage(array $page) { 64 60 $buildables = array(); 65 61
-4
src/applications/harbormaster/query/HarbormasterBuildStepQuery.php
··· 26 26 return new HarbormasterBuildStep(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php
··· 69 69 return new HarbormasterBuildTarget(); 70 70 } 71 71 72 - protected function loadPage() { 73 - return $this->loadStandardPage($this->newResultObject()); 74 - } 75 - 76 72 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 77 73 $where = parent::buildWhereClauseParts($conn); 78 74
-4
src/applications/harbormaster/query/HarbormasterBuildUnitMessageQuery.php
··· 26 26 return new HarbormasterBuildUnitMessage(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/harbormaster/query/HarbormasterBuildableQuery.php
··· 63 63 return new HarbormasterBuildable(); 64 64 } 65 65 66 - protected function loadPage() { 67 - return $this->loadStandardPage($this->newResultObject()); 68 - } 69 - 70 66 protected function willFilterPage(array $page) { 71 67 $buildables = array(); 72 68
-4
src/applications/herald/query/HeraldRuleQuery.php
··· 86 86 return new HeraldRule(); 87 87 } 88 88 89 - protected function loadPage() { 90 - return $this->loadStandardPage($this->newResultObject()); 91 - } 92 - 93 89 protected function willFilterPage(array $rules) { 94 90 $rule_ids = mpull($rules, 'getID'); 95 91
-4
src/applications/herald/query/HeraldWebhookQuery.php
··· 26 26 return new HeraldWebhook(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/herald/query/HeraldWebhookRequestQuery.php
··· 29 29 return new HeraldWebhookRequest(); 30 30 } 31 31 32 - protected function loadPage() { 33 - return $this->loadStandardPage($this->newResultObject()); 34 - } 35 - 36 32 public function withLastRequestEpochBetween($epoch_min, $epoch_max) { 37 33 $this->lastRequestEpochMin = $epoch_min; 38 34 $this->lastRequestEpochMax = $epoch_max;
-4
src/applications/legalpad/query/LegalpadDocumentQuery.php
··· 81 81 return new LegalpadDocument(); 82 82 } 83 83 84 - protected function loadPage() { 85 - return $this->loadStandardPage($this->newResultObject()); 86 - } 87 - 88 84 protected function willFilterPage(array $documents) { 89 85 if ($this->needDocumentBodies) { 90 86 $documents = $this->loadDocumentBodies($documents);
-4
src/applications/macro/query/PhabricatorMacroQuery.php
··· 100 100 return new PhabricatorFileImageMacro(); 101 101 } 102 102 103 - protected function loadPage() { 104 - return $this->loadStandardPage(new PhabricatorFileImageMacro()); 105 - } 106 - 107 103 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 108 104 $where = parent::buildWhereClauseParts($conn); 109 105
-4
src/applications/metamta/query/PhabricatorMetaMTAMailPropertiesQuery.php
··· 20 20 return new PhabricatorMetaMTAMailProperties(); 21 21 } 22 22 23 - protected function loadPage() { 24 - return $this->loadStandardPage($this->newResultObject()); 25 - } 26 - 27 23 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 28 24 $where = parent::buildWhereClauseParts($conn); 29 25
-4
src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php
··· 36 36 return $this; 37 37 } 38 38 39 - protected function loadPage() { 40 - return $this->loadStandardPage($this->newResultObject()); 41 - } 42 - 43 39 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 44 40 $where = parent::buildWhereClauseParts($conn); 45 41
-4
src/applications/nuance/query/NuanceImportCursorDataQuery.php
··· 26 26 return new NuanceImportCursorData(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/nuance/query/NuanceItemCommandQuery.php
··· 26 26 return new NuanceItemCommand(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/nuance/query/NuanceItemQuery.php
··· 56 56 return new NuanceItem(); 57 57 } 58 58 59 - protected function loadPage() { 60 - return $this->loadStandardPage($this->newResultObject()); 61 - } 62 - 63 59 protected function willFilterPage(array $items) { 64 60 $viewer = $this->getViewer(); 65 61 $source_phids = mpull($items, 'getSourcePHID');
-4
src/applications/nuance/query/NuanceQueueQuery.php
··· 20 20 return new NuanceQueue(); 21 21 } 22 22 23 - protected function loadPage() { 24 - return $this->loadStandardPage($this->newResultObject()); 25 - } 26 - 27 23 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 28 24 $where = parent::buildWhereClauseParts($conn); 29 25
-4
src/applications/nuance/query/NuanceSourceQuery.php
··· 48 48 return 'source'; 49 49 } 50 50 51 - protected function loadPage() { 52 - return $this->loadStandardPage($this->newResultObject()); 53 - } 54 - 55 51 protected function willFilterPage(array $sources) { 56 52 $all_types = NuanceSourceDefinition::getAllDefinitions(); 57 53
-4
src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php
··· 26 26 return new PhabricatorOAuthClientAuthorization(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function willFilterPage(array $authorizations) { 34 30 $client_phids = mpull($authorizations, 'getClientPHID'); 35 31
-4
src/applications/owners/query/PhabricatorOwnersPackageQuery.php
··· 102 102 $this->controlResults = array(); 103 103 } 104 104 105 - protected function loadPage() { 106 - return $this->loadStandardPage($this->newResultObject()); 107 - } 108 - 109 105 protected function willFilterPage(array $packages) { 110 106 $package_ids = mpull($packages, 'getID'); 111 107
-4
src/applications/packages/query/PhabricatorPackagesPackageQuery.php
··· 44 44 return new PhabricatorPackagesPackage(); 45 45 } 46 46 47 - protected function loadPage() { 48 - return $this->loadStandardPage($this->newResultObject()); 49 - } 50 - 51 47 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 52 48 $where = parent::buildWhereClauseParts($conn); 53 49
-4
src/applications/packages/query/PhabricatorPackagesPublisherQuery.php
··· 32 32 return new PhabricatorPackagesPublisher(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/packages/query/PhabricatorPackagesVersionQuery.php
··· 44 44 return new PhabricatorPackagesVersion(); 45 45 } 46 46 47 - protected function loadPage() { 48 - return $this->loadStandardPage($this->newResultObject()); 49 - } 50 - 51 47 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 52 48 $where = parent::buildWhereClauseParts($conn); 53 49
-4
src/applications/passphrase/query/PassphraseCredentialQuery.php
··· 57 57 return new PassphraseCredential(); 58 58 } 59 59 60 - protected function loadPage() { 61 - return $this->loadStandardPage($this->newResultObject()); 62 - } 63 - 64 60 protected function willFilterPage(array $page) { 65 61 if ($this->needSecrets) { 66 62 $secret_ids = mpull($page, 'getSecretID');
-4
src/applications/paste/query/PhabricatorPasteQuery.php
··· 84 84 return new PhabricatorPaste(); 85 85 } 86 86 87 - protected function loadPage() { 88 - return $this->loadStandardPage(new PhabricatorPaste()); 89 - } 90 - 91 87 protected function didFilterPage(array $pastes) { 92 88 if ($this->needRawContent) { 93 89 $pastes = $this->loadRawContent($pastes);
-4
src/applications/people/query/PhabricatorPeopleLogQuery.php
··· 58 58 return new PhabricatorUserLog(); 59 59 } 60 60 61 - protected function loadPage() { 62 - return $this->loadStandardPage($this->newResultObject()); 63 - } 64 - 65 61 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 66 62 $where = parent::buildWhereClauseParts($conn); 67 63
-4
src/applications/people/query/PhabricatorPeopleQuery.php
··· 162 162 return new PhabricatorUser(); 163 163 } 164 164 165 - protected function loadPage() { 166 - return $this->loadStandardPage($this->newResultObject()); 167 - } 168 - 169 165 protected function didFilterPage(array $users) { 170 166 if ($this->needProfile) { 171 167 $user_list = mpull($users, null, 'getPHID');
-4
src/applications/people/query/PhabricatorPeopleUserEmailQuery.php
··· 20 20 return new PhabricatorUserEmail(); 21 21 } 22 22 23 - protected function loadPage() { 24 - return $this->loadStandardPage($this->newResultObject()); 25 - } 26 - 27 23 protected function getPrimaryTableAlias() { 28 24 return 'email'; 29 25 }
-4
src/applications/phame/query/PhameBlogQuery.php
··· 45 45 return new PhameBlog(); 46 46 } 47 47 48 - protected function loadPage() { 49 - return $this->loadStandardPage($this->newResultObject()); 50 - } 51 - 52 48 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 53 49 $where = parent::buildWhereClauseParts($conn); 54 50
-4
src/applications/phame/query/PhamePostQuery.php
··· 50 50 return new PhamePost(); 51 51 } 52 52 53 - protected function loadPage() { 54 - return $this->loadStandardPage($this->newResultObject()); 55 - } 56 - 57 53 protected function willFilterPage(array $posts) { 58 54 // We require blogs to do visibility checks, so load them unconditionally. 59 55 $blog_phids = mpull($posts, 'getBlogPHID');
-4
src/applications/pholio/query/PholioImageQuery.php
··· 44 44 return new PholioImage(); 45 45 } 46 46 47 - protected function loadPage() { 48 - return $this->loadStandardPage($this->newResultObject()); 49 - } 50 - 51 47 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 52 48 $where = parent::buildWhereClauseParts($conn); 53 49
-4
src/applications/phortune/query/PhortuneAccountEmailQuery.php
··· 38 38 return new PhortuneAccountEmail(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function willFilterPage(array $addresses) { 46 42 $accounts = id(new PhortuneAccountQuery()) 47 43 ->setViewer($this->getViewer())
-4
src/applications/phortune/query/PhortuneAccountQuery.php
··· 46 46 return new PhortuneAccount(); 47 47 } 48 48 49 - protected function loadPage() { 50 - return $this->loadStandardPage($this->newResultObject()); 51 - } 52 - 53 49 protected function willFilterPage(array $accounts) { 54 50 $query = id(new PhabricatorEdgeQuery()) 55 51 ->withSourcePHIDs(mpull($accounts, 'getPHID'))
-4
src/applications/phortune/query/PhortuneMerchantQuery.php
··· 32 32 return new PhortuneMerchant(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function willFilterPage(array $merchants) { 40 36 $query = id(new PhabricatorEdgeQuery()) 41 37 ->withSourcePHIDs(mpull($merchants, 'getPHID'))
-4
src/applications/phortune/query/PhortunePaymentMethodQuery.php
··· 38 38 return new PhortunePaymentMethod(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function willFilterPage(array $methods) { 46 42 $accounts = id(new PhortuneAccountQuery()) 47 43 ->setViewer($this->getViewer())
-4
src/applications/phortune/query/PhortuneSubscriptionQuery.php
··· 51 51 return new PhortuneSubscription(); 52 52 } 53 53 54 - protected function loadPage() { 55 - return $this->loadStandardPage($this->newResultObject()); 56 - } 57 - 58 54 protected function willFilterPage(array $subscriptions) { 59 55 $accounts = id(new PhortuneAccountQuery()) 60 56 ->setViewer($this->getViewer())
-4
src/applications/phriction/query/PhrictionContentQuery.php
··· 32 32 return new PhrictionContent(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/phriction/query/PhrictionDocumentQuery.php
··· 62 62 return $this; 63 63 } 64 64 65 - protected function loadPage() { 66 - return $this->loadStandardPage($this->newResultObject()); 67 - } 68 - 69 65 public function newResultObject() { 70 66 return new PhrictionDocument(); 71 67 }
-4
src/applications/phurl/query/PhabricatorPhurlURLQuery.php
··· 50 50 return $this; 51 51 } 52 52 53 - protected function loadPage() { 54 - return $this->loadStandardPage($this->newResultObject()); 55 - } 56 - 57 53 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 58 54 $where = parent::buildWhereClauseParts($conn); 59 55
-4
src/applications/ponder/query/PonderAnswerQuery.php
··· 59 59 return new PonderAnswer(); 60 60 } 61 61 62 - protected function loadPage() { 63 - return $this->loadStandardPage(new PonderAnswer()); 64 - } 65 - 66 62 protected function willFilterPage(array $answers) { 67 63 $questions = id(new PonderQuestionQuery()) 68 64 ->setViewer($this->getViewer())
-4
src/applications/ponder/query/PonderQuestionQuery.php
··· 86 86 return new PonderQuestion(); 87 87 } 88 88 89 - protected function loadPage() { 90 - return $this->loadStandardPage(new PonderQuestion()); 91 - } 92 - 93 89 protected function willFilterPage(array $questions) { 94 90 95 91 $phids = mpull($questions, 'getPHID');
-4
src/applications/project/query/PhabricatorProjectColumnPositionQuery.php
··· 32 32 return new PhabricatorProjectColumnPosition(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = array(); 41 37
-4
src/applications/project/query/PhabricatorProjectColumnQuery.php
··· 56 56 return new PhabricatorProjectColumn(); 57 57 } 58 58 59 - protected function loadPage() { 60 - return $this->loadStandardPage($this->newResultObject()); 61 - } 62 - 63 59 protected function willFilterPage(array $page) { 64 60 $projects = array(); 65 61
-4
src/applications/project/query/PhabricatorProjectQuery.php
··· 236 236 } 237 237 } 238 238 239 - protected function loadPage() { 240 - return $this->loadStandardPage($this->newResultObject()); 241 - } 242 - 243 239 protected function willFilterPage(array $projects) { 244 240 $ancestor_paths = array(); 245 241 foreach ($projects as $project) {
-4
src/applications/project/query/PhabricatorProjectTriggerQuery.php
··· 35 35 return new PhabricatorProjectTrigger(); 36 36 } 37 37 38 - protected function loadPage() { 39 - return $this->loadStandardPage($this->newResultObject()); 40 - } 41 - 42 38 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 43 39 $where = parent::buildWhereClauseParts($conn); 44 40
-4
src/applications/repository/query/PhabricatorRepositoryGitLFSRefQuery.php
··· 26 26 return new PhabricatorRepositoryGitLFSRef(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php
··· 66 66 return 'identity'; 67 67 } 68 68 69 - protected function loadPage() { 70 - return $this->loadStandardPage($this->newResultObject()); 71 - } 72 - 73 69 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 74 70 $where = parent::buildWhereClauseParts($conn); 75 71
-4
src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php
··· 40 40 return new PhabricatorRepositoryPullEvent(); 41 41 } 42 42 43 - protected function loadPage() { 44 - return $this->loadStandardPage($this->newResultObject()); 45 - } 46 - 47 43 protected function willFilterPage(array $events) { 48 44 // If a pull targets an invalid repository or fails before authenticating, 49 45 // it may not have an associated repository.
-4
src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php
··· 38 38 return new PhabricatorRepositoryPushEvent(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function willFilterPage(array $events) { 46 42 $repository_phids = mpull($events, 'getRepositoryPHID'); 47 43 $repositories = id(new PhabricatorRepositoryQuery())
-4
src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php
··· 64 64 return new PhabricatorRepositoryPushLog(); 65 65 } 66 66 67 - protected function loadPage() { 68 - return $this->loadStandardPage($this->newResultObject()); 69 - } 70 - 71 67 protected function willFilterPage(array $logs) { 72 68 $event_phids = mpull($logs, 'getPushEventPHID'); 73 69 $events = id(new PhabricatorObjectQuery())
-4
src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php
··· 50 50 return new PhabricatorRepositoryRefCursor(); 51 51 } 52 52 53 - protected function loadPage() { 54 - return $this->loadStandardPage($this->newResultObject()); 55 - } 56 - 57 53 protected function willFilterPage(array $refs) { 58 54 $repository_phids = mpull($refs, 'getRepositoryPHID'); 59 55
-4
src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php
··· 34 34 return new PhabricatorRepositorySyncEvent(); 35 35 } 36 36 37 - protected function loadPage() { 38 - return $this->loadStandardPage($this->newResultObject()); 39 - } 40 - 41 37 protected function willFilterPage(array $events) { 42 38 $repository_phids = mpull($events, 'getRepositoryPHID'); 43 39 $repository_phids = array_filter($repository_phids);
-4
src/applications/repository/query/PhabricatorRepositoryURIQuery.php
··· 34 34 return new PhabricatorRepositoryURI(); 35 35 } 36 36 37 - protected function loadPage() { 38 - return $this->loadStandardPage($this->newResultObject()); 39 - } 40 - 41 37 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 42 38 $where = parent::buildWhereClauseParts($conn); 43 39
-4
src/applications/search/query/PhabricatorNamedQueryConfigQuery.php
··· 26 26 return new PhabricatorNamedQueryConfig(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/search/query/PhabricatorNamedQueryQuery.php
··· 32 32 return new PhabricatorNamedQuery(); 33 33 } 34 34 35 - protected function loadPage() { 36 - return $this->loadStandardPage($this->newResultObject()); 37 - } 38 - 39 35 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 40 36 $where = parent::buildWhereClauseParts($conn); 41 37
-4
src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php
··· 40 40 return new PhabricatorProfileMenuItemConfiguration(); 41 41 } 42 42 43 - protected function loadPage() { 44 - return $this->loadStandardPage($this->newResultObject()); 45 - } 46 - 47 43 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 48 44 $where = parent::buildWhereClauseParts($conn); 49 45
-4
src/applications/slowvote/query/PhabricatorSlowvoteQuery.php
··· 57 57 return new PhabricatorSlowvotePoll(); 58 58 } 59 59 60 - protected function loadPage() { 61 - return $this->loadStandardPage($this->newResultObject()); 62 - } 63 - 64 60 protected function willFilterPage(array $polls) { 65 61 assert_instances_of($polls, 'PhabricatorSlowvotePoll'); 66 62
+2 -2
src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
··· 36 36 return 'PhabricatorSpacesApplication'; 37 37 } 38 38 39 - protected function loadPage() { 40 - return $this->loadStandardPage(new PhabricatorSpacesNamespace()); 39 + public function newResultObject() { 40 + return new PhabricatorSpacesNamespace(); 41 41 } 42 42 43 43 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
-4
src/applications/tokens/query/PhabricatorTokenGivenQuery.php
··· 26 26 return new PhabricatorTokenGiven(); 27 27 } 28 28 29 - protected function loadPage() { 30 - return $this->loadStandardPage($this->newResultObject()); 31 - } 32 - 33 29 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 34 30 $where = parent::buildWhereClauseParts($conn); 35 31
-4
src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php
··· 46 46 return $this->newApplicationTransactionCommentTemplate(); 47 47 } 48 48 49 - protected function loadPage() { 50 - return $this->loadStandardPage($this->newResultObject()); 51 - } 52 - 53 49 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 54 50 $where = parent::buildWhereClauseParts($conn); 55 51 $alias = $this->getPrimaryTableAlias();
-4
src/applications/xhprof/query/PhabricatorXHProfSampleQuery.php
··· 20 20 return new PhabricatorXHProfSample(); 21 21 } 22 22 23 - protected function loadPage() { 24 - return $this->loadStandardPage($this->newResultObject()); 25 - } 26 - 27 23 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { 28 24 $where = parent::buildWhereClauseParts($conn); 29 25
-4
src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobQuery.php
··· 38 38 return new PhabricatorWorkerBulkJob(); 39 39 } 40 40 41 - protected function loadPage() { 42 - return $this->loadStandardPage($this->newResultObject()); 43 - } 44 - 45 41 protected function willFilterPage(array $page) { 46 42 $map = PhabricatorWorkerBulkJobType::getAllJobTypes(); 47 43
+18
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
··· 265 265 return $this->ferretMetadata; 266 266 } 267 267 268 + protected function loadPage() { 269 + $object = $this->newResultObject(); 270 + 271 + if (!$object instanceof PhabricatorLiskDAO) { 272 + throw new Exception( 273 + pht( 274 + 'Query class ("%s") did not return the correct type of object '. 275 + 'from "newResultObject()" (expected a subclass of '. 276 + '"PhabricatorLiskDAO", found "%s"). Return an object of the '. 277 + 'expected type (this is common), or implement a custom '. 278 + '"loadPage()" method (this is unusual in modern code).', 279 + get_class($this), 280 + phutil_describe_type($object))); 281 + } 282 + 283 + return $this->loadStandardPage($object); 284 + } 285 + 268 286 protected function loadStandardPage(PhabricatorLiskDAO $table) { 269 287 $rows = $this->loadStandardPageRows($table); 270 288 return $table->loadAllFromArray($rows);