@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add "unblock" and "column" mail tags to Maniphest
Summary: Fixes T5769. Fixes T5861. Add mail tags for "unblock" and "column change".
Test Plan: Did unblocks and column changes, verified the mail got the right mailtags and recipient nondelivery flags.
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T5861, T5769
Differential Revision: https://secure.phabricator.com/D10241
+38
-24
+12
-8
src/applications/maniphest/editor/ManiphestTransactionEditor.php
+12
-8
src/applications/maniphest/editor/ManiphestTransactionEditor.php
···
438
438
439
439
public function getMailTagsMap() {
440
440
return array(
441
-
MetaMTANotificationType::TYPE_MANIPHEST_STATUS =>
441
+
ManiphestTransaction::MAILTAG_STATUS =>
442
442
pht("A task's status changes."),
443
-
MetaMTANotificationType::TYPE_MANIPHEST_OWNER =>
443
+
ManiphestTransaction::MAILTAG_OWNER =>
444
444
pht("A task's owner changes."),
445
-
MetaMTANotificationType::TYPE_MANIPHEST_PRIORITY =>
445
+
ManiphestTransaction::MAILTAG_PRIORITY =>
446
446
pht("A task's priority changes."),
447
-
MetaMTANotificationType::TYPE_MANIPHEST_CC =>
448
-
pht("A task's CCs change."),
449
-
MetaMTANotificationType::TYPE_MANIPHEST_PROJECTS =>
447
+
ManiphestTransaction::MAILTAG_CC =>
448
+
pht("A task's subscribers change."),
449
+
ManiphestTransaction::MAILTAG_PROJECTS =>
450
450
pht("A task's associated projects change."),
451
-
MetaMTANotificationType::TYPE_MANIPHEST_COMMENT =>
451
+
ManiphestTransaction::MAILTAG_UNBLOCK =>
452
+
pht('One of the tasks a task is blocked by changes status.'),
453
+
ManiphestTransaction::MAILTAG_COLUMN =>
454
+
pht('A task is moved between columns on a workboard.'),
455
+
ManiphestTransaction::MAILTAG_COMMENT =>
452
456
pht('Someone comments on a task.'),
453
-
MetaMTANotificationType::TYPE_MANIPHEST_OTHER =>
457
+
ManiphestTransaction::MAILTAG_OTHER =>
454
458
pht('Other task activity not listed above occurs.'),
455
459
);
456
460
}
+26
-8
src/applications/maniphest/storage/ManiphestTransaction.php
+26
-8
src/applications/maniphest/storage/ManiphestTransaction.php
···
20
20
// so any transactions render correctly.
21
21
const TYPE_ATTACH = 'attach';
22
22
23
+
24
+
const MAILTAG_STATUS = 'maniphest-status';
25
+
const MAILTAG_OWNER = 'maniphest-owner';
26
+
const MAILTAG_PRIORITY = 'maniphest-priority';
27
+
const MAILTAG_CC = 'maniphest-cc';
28
+
const MAILTAG_PROJECTS = 'maniphest-projects';
29
+
const MAILTAG_COMMENT = 'maniphest-comment';
30
+
const MAILTAG_COLUMN = 'maniphest-column';
31
+
const MAILTAG_UNBLOCK = 'maniphest-unblock';
32
+
const MAILTAG_OTHER = 'maniphest-other';
33
+
34
+
23
35
public function getApplicationName() {
24
36
return 'maniphest';
25
37
}
···
828
840
$tags = array();
829
841
switch ($this->getTransactionType()) {
830
842
case self::TYPE_STATUS:
831
-
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_STATUS;
843
+
$tags[] = self::MAILTAG_STATUS;
832
844
break;
833
845
case self::TYPE_OWNER:
834
-
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_OWNER;
846
+
$tags[] = self::MAILTAG_OWNER;
835
847
break;
836
848
case self::TYPE_CCS:
837
-
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_CC;
849
+
$tags[] = self::MAILTAG_CC;
838
850
break;
839
851
case PhabricatorTransactions::TYPE_EDGE:
840
852
switch ($this->getMetadataValue('edge:type')) {
841
853
case PhabricatorProjectObjectHasProjectEdgeType::EDGECONST:
842
-
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_PROJECTS;
854
+
$tags[] = self::MAILTAG_PROJECTS;
843
855
break;
844
856
default:
845
-
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_OTHER;
857
+
$tags[] = self::MAILTAG_OTHER;
846
858
break;
847
859
}
848
860
break;
849
861
case self::TYPE_PRIORITY:
850
-
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_PRIORITY;
862
+
$tags[] = self::MAILTAG_PRIORITY;
863
+
break;
864
+
case self::TYPE_UNBLOCK:
865
+
$tags[] = self::MAILTAG_UNBLOCK;
866
+
break;
867
+
case self::TYPE_PROJECT_COLUMN:
868
+
$tags[] = self::MAILTAG_COLUMN;
851
869
break;
852
870
case PhabricatorTransactions::TYPE_COMMENT:
853
-
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_COMMENT;
871
+
$tags[] = self::MAILTAG_COMMENT;
854
872
break;
855
873
default:
856
-
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_OTHER;
874
+
$tags[] = self::MAILTAG_OTHER;
857
875
break;
858
876
}
859
877
return $tags;
-8
src/applications/metamta/constants/MetaMTANotificationType.php
-8
src/applications/metamta/constants/MetaMTANotificationType.php
···
11
11
const TYPE_DIFFERENTIAL_REVIEW_REQUEST = 'differential-review-request';
12
12
const TYPE_DIFFERENTIAL_OTHER = 'differential-other';
13
13
14
-
const TYPE_MANIPHEST_STATUS = 'maniphest-status';
15
-
const TYPE_MANIPHEST_OWNER = 'maniphest-owner';
16
-
const TYPE_MANIPHEST_PRIORITY = 'maniphest-priority';
17
-
const TYPE_MANIPHEST_CC = 'maniphest-cc';
18
-
const TYPE_MANIPHEST_PROJECTS = 'maniphest-projects';
19
-
const TYPE_MANIPHEST_COMMENT = 'maniphest-comment';
20
-
const TYPE_MANIPHEST_OTHER = 'maniphest-other';
21
-
22
14
const TYPE_PHOLIO_STATUS = 'pholio-status';
23
15
const TYPE_PHOLIO_COMMENT = 'pholio-comment';
24
16
const TYPE_PHOLIO_UPDATED = 'pholio-updated';