@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Load primary reviewer PHID
Summary: A cursory look at DifferentialReviewer suggests the primary reviewer doesn't actually have to be among the reviewers? Uploading this so bug reporter can patch and see if it helps.
Test Plan: Nope.
Reviewers: epriestley
Reviewed By: epriestley
CC: szymon, aran, Korvin
Maniphest Tasks: T1625
Differential Revision: https://secure.phabricator.com/D3198
+4
-2
+4
-2
src/applications/differential/storage/DifferentialRevision.php
+4
-2
src/applications/differential/storage/DifferentialRevision.php
···
283
283
}
284
284
285
285
public function getPrimaryReviewer() {
286
-
if (!$this->lastReviewerPHID) {
286
+
$reviewers = $this->getReviewers();
287
+
$last = $this->lastReviewerPHID;
288
+
if (!$last || !in_array($last, $reviewers)) {
287
289
return head($this->getReviewers());
288
290
}
289
-
return $this->lastReviewerPHID;
291
+
return $last;
290
292
}
291
293
292
294
public function loadReviewedBy() {