@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix quick create on mobile
Summary: Fixes T4903. At some point maybe-soonish we should maybe go make `"device" => true` the default, and put `"device" => "hella-busted"` on the remaining bad pages.
Test Plan: L@@K @ W/ iOS Simulator
Reviewers: chad
Reviewed By: chad
Subscribers: epriestley, k
Maniphest Tasks: T4903
Differential Revision: https://secure.phabricator.com/D8863
+5
-1
+1
src/applications/home/controller/PhabricatorHomeQuickCreateController.php
+1
src/applications/home/controller/PhabricatorHomeQuickCreateController.php
+4
-1
src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
+4
-1
src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
···
18
18
// username, so we'll incorrectly pick it up, but there's little to be done
19
19
// about that. We forbid terminal periods so that we can correctly capture
20
20
// "@joe" instead of "@joe." in "Hey, @joe.".
21
-
const REGEX = '/(?<!\w)@([a-zA-Z0-9._-]*[a-zA-Z0-9_-])/';
21
+
//
22
+
// We disallow "@@joe" because it creates a false positive in the common
23
+
// construction "l@@k", made popular by eBay.
24
+
const REGEX = '/(?<!\w|@)@([a-zA-Z0-9._-]*[a-zA-Z0-9_-])/';
22
25
23
26
public function apply($text) {
24
27
return preg_replace_callback(