@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix property shadowing on ActionListView after conversion to TagView
Summary:
See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an `id` property, and this new `id` property on the subclass shadows it.
Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.
Test Plan:
- Viewed a task.
- Made browser window narrow.
- Clicked `[= Actions]` button.
- After patch: saw a dropdown menu.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D17223
-10
-10
src/view/layout/PhabricatorActionListView.php
-10
src/view/layout/PhabricatorActionListView.php
···
4
4
5
5
private $actions = array();
6
6
private $object;
7
-
private $id = null;
8
7
9
8
public function setObject(PhabricatorLiskDAO $object) {
10
9
$this->object = $object;
···
14
13
public function addAction(PhabricatorActionView $view) {
15
14
$this->actions[] = $view;
16
15
return $this;
17
-
}
18
-
19
-
public function setID($id) {
20
-
$this->id = $id;
21
-
return $this;
22
-
}
23
-
24
-
public function getID() {
25
-
return $this->id;
26
16
}
27
17
28
18
protected function getTagName() {