@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Misc Phame Updates
Summary: Color nodata as nodata, fix picture redirect, give hints when items aren't set on blogs. Ref T9897
Test Plan: Tested each of these items.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T9897
Differential Revision: https://secure.phabricator.com/D14657
+14
-8
+11
-6
src/applications/phame/controller/blog/PhameBlogManageController.php
+11
-6
src/applications/phame/controller/blog/PhameBlogManageController.php
···
80
80
->setObject($blog)
81
81
->setActionList($actions);
82
82
83
-
$properties->addProperty(
84
-
pht('Skin'),
85
-
$blog->getSkin());
83
+
$skin = $blog->getSkin();
84
+
if (!$skin) {
85
+
$skin = pht('(No external skin)');
86
+
}
87
+
88
+
$domain = $blog->getDomain();
89
+
if (!$domain) {
90
+
$domain = pht('(No external domain)');
91
+
}
86
92
87
-
$properties->addProperty(
88
-
pht('Domain'),
89
-
$blog->getDomain());
93
+
$properties->addProperty(pht('Skin'), $skin);
94
+
$properties->addProperty(pht('Domain'), $domain);
90
95
91
96
$feed_uri = PhabricatorEnv::getProductionURI(
92
97
$this->getApplicationURI('blog/feed/'.$blog->getID().'/'));
+1
-1
src/applications/phame/controller/blog/PhameBlogProfilePictureController.php
+1
-1
src/applications/phame/controller/blog/PhameBlogProfilePictureController.php
+2
-1
src/applications/phame/view/PhamePostListView.php
+2
-1
src/applications/phame/view/PhamePostListView.php
···
57
57
$phame_post = PhabricatorMarkupEngine::summarize($post->getBody());
58
58
$phame_post = new PHUIRemarkupView($viewer, $phame_post);
59
59
} else {
60
-
$phame_post = phutil_tag('em', array(), pht('Empty Post'));
60
+
$phame_post = phutil_tag('em', array(), pht('(Empty Post)'));
61
61
}
62
62
63
63
$blogger = phutil_tag('strong', array(), $blogger);
···
101
101
102
102
if (empty($list)) {
103
103
$list = id(new PHUIInfoView())
104
+
->setSeverity(PHUIInfoView::SEVERITY_NODATA)
104
105
->appendChild($nodata);
105
106
}
106
107