recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Load relationships for revision

Summary:
In the commit message parser worker, it tries to get relationships for a
revision without first loading them. (D3444 introduced the change.) This
is where the get happens, so I'm adding the load here - maybe it should be
added in the CommitMessageParserWorker instead?

Test Plan: Made this change, and my taskmaster daemons stopped failing.

Reviewers: epriestley, vrana

Reviewed By: vrana

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3448

Nick Harper 90b60bc3 958e6cd1

+1
+1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
··· 102 102 if ($revision_id) { 103 103 $revision = id(new DifferentialRevision())->load($revision_id); 104 104 if ($revision) { 105 + $revision->loadRelationships(); 105 106 queryfx( 106 107 $conn_w, 107 108 'INSERT IGNORE INTO %T (revisionID, commitPHID) VALUES (%d, %s)',