recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue with editing application default policies in Calendar

Summary: Ref T11816. We're running this code on empty events which haven't been initialized and don't have a source attached -- just use a more explanatory check which doesn't need anything attached.

Test Plan: Edited default Calendar policies.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11816

Differential Revision: https://secure.phabricator.com/D16803

epriestley 90fb8a15 e3370297

+3 -3
+3 -3
src/applications/calendar/storage/PhabricatorCalendarEvent.php
··· 1169 1169 case PhabricatorPolicyCapability::CAN_VIEW: 1170 1170 return $this->getViewPolicy(); 1171 1171 case PhabricatorPolicyCapability::CAN_EDIT: 1172 - if ($this->getImportSource()) { 1172 + if ($this->isImportedEvent()) { 1173 1173 return PhabricatorPolicies::POLICY_NOONE; 1174 1174 } else { 1175 1175 return $this->getEditPolicy(); ··· 1178 1178 } 1179 1179 1180 1180 public function hasAutomaticCapability($capability, PhabricatorUser $viewer) { 1181 - if ($this->getImportSource()) { 1181 + if ($this->isImportedEvent()) { 1182 1182 return false; 1183 1183 } 1184 1184 ··· 1204 1204 } 1205 1205 1206 1206 public function describeAutomaticCapability($capability) { 1207 - if ($this->getImportSource()) { 1207 + if ($this->isImportedEvent()) { 1208 1208 return pht( 1209 1209 'Events imported from external sources can not be edited in '. 1210 1210 'Phabricator.');