+1

src/applications/calendar/util/CalendarTimeUtil.php

reviewed

··· 1 1 <?php 2 2 + 2 3 /** 3 4 * This class is useful for generating various time objects, relative to the 4 5 * user and their timezone.

+1 -1

src/applications/diviner/cache/DivinerAtomCache.php

reviewed

··· 13 13 private $writeAtoms = array(); 14 14 15 15 public function __construct($cache_directory) { 16 16 - return parent::__construct($cache_directory, 'diviner-atom-cache'); 16 16 + parent::__construct($cache_directory, 'diviner-atom-cache'); 17 17 } 18 18 19 19 public function delete() {

+1 -1

src/applications/diviner/cache/DivinerPublishCache.php

reviewed

··· 6 6 private $index; 7 7 8 8 public function __construct($cache_directory) { 9 9 - return parent::__construct($cache_directory, 'diviner-publish-cache'); 9 9 + parent::__construct($cache_directory, 'diviner-publish-cache'); 10 10 } 11 11 12 12

+1 -1

src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php

reviewed

··· 143 143 */ 144 144 private function getWritableEngine() { 145 145 // NOTE: We can't just load writable engines or we'll loop forever. 146 146 - $engines = PhabricatorFileStorageEngine::loadAllEngines(); 146 146 + $engines = parent::loadAllEngines(); 147 147 148 148 foreach ($engines as $engine) { 149 149 if ($engine->isChunkEngine()) {

+1 -1

src/applications/home/controller/PhabricatorHomeMainController.php

reviewed

··· 219 219 220 220 $revisions = $revision_query->execute(); 221 221 222 222 - list($blocking, $active,) = DifferentialRevisionQuery::splitResponsible( 222 222 + list($blocking, $active) = DifferentialRevisionQuery::splitResponsible( 223 223 $revisions, 224 224 array($user_phid)); 225 225

+1 -2

src/applications/oauthserver/PhabricatorOAuthResponse.php

reviewed

··· 65 65 } 66 66 67 67 public function __construct() { 68 68 - $this->setHTTPResponseCode(200); // assume the best 69 69 - return $this; 68 68 + $this->setHTTPResponseCode(200); // assume the best 70 69 } 71 70 72 71 public function getHeaders() {

+2 -2

src/applications/oauthserver/PhabricatorOAuthServer.php

reviewed

··· 64 64 */ 65 65 public function userHasAuthorizedClient(array $scope) { 66 66 67 67 - $authorization = id(new PhabricatorOAuthClientAuthorization())-> 68 68 - loadOneWhere( 67 67 + $authorization = id(new PhabricatorOAuthClientAuthorization()) 68 68 + ->loadOneWhere( 69 69 'userPHID = %s AND clientPHID = %s', 70 70 $this->getUser()->getPHID(), 71 71 $this->getClient()->getPHID());

+1 -3

src/applications/phame/controller/PhameController.php

reviewed

··· 1 1 <?php 2 2 3 3 - abstract class PhameController extends PhabricatorController { 4 4 - 5 5 - } 3 3 + abstract class PhameController extends PhabricatorController {}

+1 -1

src/applications/releeph/storage/ReleephRequestTransaction.php

reviewed

··· 77 77 78 78 $markup = $name; 79 79 if ($this->getRenderingTarget() === 80 80 - PhabricatorApplicationTransaction::TARGET_HTML) { 80 80 + parent::TARGET_HTML) { 81 81 82 82 $markup = hsprintf('<em>%s</em>', $name); 83 83 }

+1 -1

src/infrastructure/lint/linter/PhabricatorJavelinLinter.php

reviewed

··· 85 85 } 86 86 87 87 public function getCacheGranularity() { 88 88 - return ArcanistLinter::GRANULARITY_REPOSITORY; 88 88 + return parent::GRANULARITY_REPOSITORY; 89 89 } 90 90 91 91 public function getCacheVersion() {

+1 -1

src/view/widget/bars/AphrontGlyphBarView.php

reviewed

··· 12 12 private $bgGlyph; 13 13 14 14 protected function getDefaultColor() { 15 15 - return AphrontBarView::COLOR_AUTO_GOODNESS; 15 15 + return parent::COLOR_AUTO_GOODNESS; 16 16 } 17 17 18 18 public function setValue($value) {

+1 -1

src/view/widget/bars/AphrontProgressBarView.php

reviewed

··· 9 9 private $alt = ''; 10 10 11 11 protected function getDefaultColor() { 12 12 - return AphrontBarView::COLOR_AUTO_BADNESS; 12 12 + return parent::COLOR_AUTO_BADNESS; 13 13 } 14 14 15 15 public function setValue($value) {