@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field
Summary:
Depends on D20426. Ref T13277. The new behavior is to fire Herald only once a commit becomes reachable from a permanent ref (previously, an "Autoclose" branch).
That means that every "Commit" Herald rule implicitly has this field as a condition, and it no longer does anything.
Test Plan: Wrote a Herald rule, saw this as an option in the "Deprecated" section.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13277
Differential Revision: https://secure.phabricator.com/D20427
+8
-2
+8
-2
src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php
+8
-2
src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php
···
5
5
6
6
const FIELDCONST = 'diffusion.commit.autoclose';
7
7
8
+
public function getFieldGroupKey() {
9
+
return HeraldDeprecatedFieldGroup::FIELDGROUPKEY;
10
+
}
11
+
8
12
public function getHeraldFieldName() {
9
-
return pht('Commit is on permanent branch');
13
+
// Herald no longer triggers until a commit is reachable from a permanent
14
+
// ref, so this condition is always true by definition.
15
+
return pht('Commit Autocloses (Deprecated)');
10
16
}
11
17
12
18
public function getHeraldFieldValue($object) {
13
-
return $object->getRepository()->shouldAutocloseCommit($object);
19
+
return true;
14
20
}
15
21
16
22
public function getHeraldFieldConditions() {