@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Subversion - set minimum required version to 1.5

Summary: Fixes T7228.

Test Plan: hacked $version to be '1.4' and saw the proper error message

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7228

Differential Revision: https://secure.phabricator.com/D11732

+2 -3
+2 -3
src/applications/config/check/PhabricatorBinariesSetupCheck.php
··· 102 102 $version = trim(substr($stdout, strlen('git version '))); 103 103 break; 104 104 case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: 105 - $minimum_version = null; 105 + $minimum_version = '1.5'; 106 106 $bad_versions = array( 107 107 '1.7.1' => pht('This version of Subversion has a bug where '. 108 108 '"svn diff -c N" does not work for files added '. 109 - 'in rN (Subverison issue #2873), fixed in 1.7.2.'),); 109 + 'in rN (Subversion issue #2873), fixed in 1.7.2.'),); 110 110 list($err, $stdout, $stderr) = exec_manual('svn --version --quiet'); 111 111 $version = trim($stdout); 112 112 break; ··· 232 232 case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: 233 233 break; 234 234 case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: 235 - break; 236 235 case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: 237 236 $summary = pht( 238 237 "The '%s' binary is version %s and Phabricator requires version ".