recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make some confusing/weird Calendar fields not configurable on custom EditEngine forms

Summary:
Ref T11816.

- Host gets weird behavior around defaulting to the viewer.
- Invitees get weird behavior around defaulting to the viewer.
- "All Day" is just sort of weird since start / end date aren't customizable.
- Recurring/Frequency are weird here and don't make much sense.

I can't immediately come up with reasons that any of these are particularly useful/valuable to default. More of them can be made editable after T10222 gets sorted out.

Test Plan: Edited edit engine custom forms for Calendar events, saw a more sensible list of customizable fields (e.g., policy stuff).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11816

Differential Revision: https://secure.phabricator.com/D16878

epriestley 91ee6b78 78bd6c1c

+10
+10
src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php
··· 108 108 ->setConduitTypeDescription(pht('New event name.')) 109 109 ->setValue($object->getName()), 110 110 id(new PhabricatorBoolEditField()) 111 + ->setIsLockable(false) 112 + ->setIsDefaultable(false) 111 113 ->setKey('isAllDay') 112 114 ->setOptions(pht('Normal Event'), pht('All Day Event')) 113 115 ->setAsCheckbox(true) ··· 151 153 ->setConduitTypeDescription(pht('True to cancel the event.')) 152 154 ->setValue($object->getIsCancelled()), 153 155 id(new PhabricatorUsersEditField()) 156 + ->setIsLockable(false) 157 + ->setIsDefaultable(false) 154 158 ->setKey('hostPHID') 155 159 ->setAliases(array('host')) 156 160 ->setLabel(pht('Host')) ··· 162 166 ->setConduitTypeDescription(pht('New event host.')) 163 167 ->setSingleValue($object->getHostPHID()), 164 168 id(new PhabricatorDatasourceEditField()) 169 + ->setIsLockable(false) 170 + ->setIsDefaultable(false) 165 171 ->setIsHidden($is_future) 166 172 ->setKey('inviteePHIDs') 167 173 ->setAliases(array('invite', 'invitee', 'invitees', 'inviteePHID')) ··· 203 209 204 210 id(new PhabricatorBoolEditField()) 205 211 ->setIsHidden(true) 212 + ->setIsLockable(false) 213 + ->setIsDefaultable(false) 206 214 ->setKey('isRecurring') 207 215 ->setLabel(pht('Recurring')) 208 216 ->setOptions(pht('One-Time Event'), pht('Recurring Event')) ··· 213 221 ->setConduitTypeDescription(pht('Mark the event as a recurring event.')) 214 222 ->setValue(true), 215 223 id(new PhabricatorSelectEditField()) 224 + ->setIsLockable(false) 225 + ->setIsDefaultable(false) 216 226 ->setKey('frequency') 217 227 ->setLabel(pht('Frequency')) 218 228 ->setOptions($frequency_options)