@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Push typehead browse result selector button down one <div>
Summary: Fixes T11190. The div with all the stuff in it was sometimes ending up on top of the "select" button, making it unclickable.
Test Plan: Clicked "select" in several browsers.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11190
Differential Revision: https://secure.phabricator.com/D16160
+8
-7
+8
-7
src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
+8
-7
src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
···
143
143
144
144
$items = array();
145
145
foreach ($results as $result) {
146
-
$information = $this->renderBrowseResult($result);
147
-
148
146
// Disable already-selected tokens.
149
147
$disabled = isset($exclude[$result->getPHID()]);
150
148
···
161
159
),
162
160
pht('Select'));
163
161
162
+
$information = $this->renderBrowseResult($result, $button);
163
+
164
164
$items[] = phutil_tag(
165
165
'div',
166
166
array(
167
167
'class' => 'typeahead-browse-item grouped',
168
168
),
169
-
array(
170
-
$button,
171
-
$information,
172
-
));
169
+
$information);
173
170
}
174
171
175
172
$markup = array(
···
352
349
->appendChild($view);
353
350
}
354
351
355
-
private function renderBrowseResult(PhabricatorTypeaheadResult $result) {
352
+
private function renderBrowseResult(
353
+
PhabricatorTypeaheadResult $result,
354
+
$button) {
355
+
356
356
$class = array();
357
357
$style = array();
358
358
$separator = " \xC2\xB7 ";
···
399
399
'style' => implode(' ', $style),
400
400
),
401
401
array(
402
+
$button,
402
403
$name,
403
404
$attributes,
404
405
));