@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make repository URI creation work regardless of "repository" transaction order
Summary: Fixes T11276. This feels slightly iffy (we `attachRepository()` here, and also when applying the TYPE_REPOSITORY transaction) but simpler than trying to reorder things.
Test Plan: Created a repository URI with transactions in `["uri", "repository"]` order.
Reviewers: chad, avivey
Reviewed By: avivey
Maniphest Tasks: T11276
Differential Revision: https://secure.phabricator.com/D16237
+5
+5
src/applications/diffusion/editor/DiffusionURIEditor.php
+5
src/applications/diffusion/editor/DiffusionURIEditor.php
···
77
77
$old_uri = $object->getEffectiveURI();
78
78
} else {
79
79
$old_uri = null;
80
+
81
+
// When creating a URI, we may not have processed the repository
82
+
// transaction yet. Attach the repository here to make sure we
83
+
// have it for the calls below.
84
+
$object->attachRepository($this->repository);
80
85
}
81
86
82
87
$object->setURI($xaction->getNewValue());