@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove Similar Questions column from Ponder
Summary: Not terribly useful. Also removed close your stuff reminder.
Test Plan: View question I asked and strangers question. Both layout more normal like.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15312
+7
-81
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
92
92
'rsrc/css/application/policy/policy-edit.css' => '815c66f7',
93
93
'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43',
94
94
'rsrc/css/application/policy/policy.css' => '957ea14c',
95
-
'rsrc/css/application/ponder/ponder-view.css' => '4486434b',
95
+
'rsrc/css/application/ponder/ponder-view.css' => 'b40dc156',
96
96
'rsrc/css/application/project/project-card-view.css' => '9418c97d',
97
97
'rsrc/css/application/project/project-view.css' => '83bb6654',
98
98
'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733',
···
855
855
'policy-css' => '957ea14c',
856
856
'policy-edit-css' => '815c66f7',
857
857
'policy-transaction-detail-css' => '82100a43',
858
-
'ponder-view-css' => '4486434b',
858
+
'ponder-view-css' => 'b40dc156',
859
859
'project-card-view-css' => '9418c97d',
860
860
'project-view-css' => '83bb6654',
861
861
'releeph-core' => '9b3c5733',
+5
-71
src/applications/ponder/controller/PonderQuestionViewController.php
+5
-71
src/applications/ponder/controller/PonderQuestionViewController.php
···
44
44
45
45
$actions = $this->buildActionListView($question);
46
46
$properties = $this->buildPropertyListView($question, $actions);
47
-
$sidebar = $this->buildSidebar($question);
48
47
49
48
$content_id = celerity_generate_unique_node_id();
50
49
$timeline = $this->buildTransactionTimeline(
···
81
80
->addPropertyList($properties)
82
81
->appendChild($footer);
83
82
84
-
if ($viewer->getPHID() == $question->getAuthorPHID()) {
85
-
$status = $question->getStatus();
86
-
$answers_list = $question->getAnswers();
87
-
if ($answers_list && ($status == PonderQuestionStatus::STATUS_OPEN)) {
88
-
$info_view = id(new PHUIInfoView())
89
-
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
90
-
->appendChild(
91
-
pht(
92
-
'If this question has been resolved, please consider closing
93
-
the question and marking the answer as helpful.'));
94
-
$object_box->setInfoView($info_view);
95
-
}
96
-
}
97
-
98
83
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
99
84
$crumbs->addTextCrumb('Q'.$id, '/Q'.$id);
100
85
···
107
92
->appendChild($answer);
108
93
}
109
94
110
-
$ponder_view = id(new PHUITwoColumnView())
111
-
->setMainColumn(array(
112
-
$object_box,
113
-
$comment_view,
114
-
$answer_wiki,
115
-
$answers,
116
-
$answer_add_panel,
117
-
))
118
-
->setSideColumn($sidebar)
119
-
->addClass('ponder-question-view');
120
-
121
95
return $this->buildApplicationPage(
122
96
array(
123
97
$crumbs,
124
-
$ponder_view,
98
+
$object_box,
99
+
$comment_view,
100
+
$answer_wiki,
101
+
$answers,
102
+
$answer_add_panel,
125
103
),
126
104
array(
127
105
'title' => 'Q'.$question->getID().' '.$question->getTitle(),
···
259
237
}
260
238
261
239
return $view;
262
-
}
263
-
264
-
private function buildSidebar(PonderQuestion $question) {
265
-
$viewer = $this->getViewer();
266
-
$status = $question->getStatus();
267
-
$id = $question->getID();
268
-
269
-
$questions = id(new PonderQuestionQuery())
270
-
->setViewer($viewer)
271
-
->withStatuses(array($status))
272
-
->withEdgeLogicPHIDs(
273
-
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
274
-
PhabricatorQueryConstraint::OPERATOR_OR,
275
-
$question->getProjectPHIDs())
276
-
->setLimit(10)
277
-
->execute();
278
-
279
-
$list = id(new PHUIObjectItemListView())
280
-
->setUser($viewer)
281
-
->setNoDataString(pht('No similar questions found.'));
282
-
283
-
foreach ($questions as $question) {
284
-
if ($id == $question->getID()) {
285
-
continue;
286
-
}
287
-
$item = new PHUIObjectItemView();
288
-
$item->setObjectName('Q'.$question->getID());
289
-
$item->setHeader($question->getTitle());
290
-
$item->setHref('/Q'.$question->getID());
291
-
$item->setObject($question);
292
-
293
-
$item->addAttribute(
294
-
pht(
295
-
'%s Answer(s)',
296
-
new PhutilNumber($question->getAnswerCount())));
297
-
298
-
$list->addItem($item);
299
-
}
300
-
301
-
$box = id(new PHUIObjectBoxView())
302
-
->setHeaderText(pht('Similar Questions'))
303
-
->setObjectList($list);
304
-
305
-
return $box;
306
240
}
307
241
308
242
}
-8
webroot/rsrc/css/application/ponder/ponder-view.css
-8
webroot/rsrc/css/application/ponder/ponder-view.css
···
14
14
border-right: 1px solid {$lightblueborder};
15
15
}
16
16
17
-
.ponder-question-view .phui-property-list-properties-wrap {
18
-
width: 66%;
19
-
}
20
-
21
-
.ponder-question-view .phui-property-list-actions {
22
-
width: 30%;
23
-
}
24
-
25
17
.ponder-answer-view {
26
18
margin-top: 16px;
27
19
}