recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow Herald to add package reviewers

Summary: Ref T10939. Packages are valid reviewers, so let Herald "Add Reviewers" and "Add Blocking Reviewers" actions add them.

Test Plan:
- Wrote a rule to add package reviewers.
- Hit the rule, saw a package reviewer added, viewed transcript.

{F1311731}

{F1311732}

{F1311733}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15917

epriestley 92b9fa47 332d787d

+3 -2
+1 -1
src/applications/differential/herald/DifferentialReviewersAddBlockingReviewersHeraldAction.php
··· 22 22 } 23 23 24 24 protected function getDatasource() { 25 - return new PhabricatorMetaMTAMailableDatasource(); 25 + return new DiffusionAuditorDatasource(); 26 26 } 27 27 28 28 public function renderActionDescription($value) {
+1 -1
src/applications/differential/herald/DifferentialReviewersAddReviewersHeraldAction.php
··· 22 22 } 23 23 24 24 protected function getDatasource() { 25 - return new PhabricatorMetaMTAMailableDatasource(); 25 + return new DiffusionAuditorDatasource(); 26 26 } 27 27 28 28 public function renderActionDescription($value) {
+1
src/applications/differential/herald/DifferentialReviewersHeraldAction.php
··· 69 69 $allowed_types = array( 70 70 PhabricatorPeopleUserPHIDType::TYPECONST, 71 71 PhabricatorProjectProjectPHIDType::TYPECONST, 72 + PhabricatorOwnersPackagePHIDType::TYPECONST, 72 73 ); 73 74 74 75 $targets = $this->loadStandardTargets($phids, $allowed_types, $current);