@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fixes broken search if no task ids created by D2771.
Summary: I forgot to handle the case where there was no task ids entered in D2771, but this corrects that issue.
Test Plan: Search with no task ids...
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T1365
Differential Revision: https://secure.phabricator.com/D2773
authored by
Jonathan Lomas
and committed by
epriestley
92fac312
5b6713f3
+14
-12
+14
-12
src/applications/maniphest/controller/ManiphestTaskListController.php
+14
-12
src/applications/maniphest/controller/ManiphestTaskListController.php
···
662
662
$exclude_project_phids = $request->getStrList('xprojects');
663
663
$task_ids = $request->getStrList('tasks');
664
664
665
-
// We only need the integer portion of each task ID, so get rid of any non-
666
-
// numeric elements
667
-
$numeric_task_ids = array();
665
+
if ($task_ids) {
666
+
// We only need the integer portion of each task ID, so get rid of any
667
+
// non-numeric elements
668
+
$numeric_task_ids = array();
668
669
669
-
foreach ($task_ids as $task_id) {
670
-
$task_id = preg_replace('/[a-zA-Z]+/', '', $task_id);
671
-
if (!empty($task_id)) {
672
-
$numeric_task_ids[] = $task_id;
670
+
foreach ($task_ids as $task_id) {
671
+
$task_id = preg_replace('/[a-zA-Z]+/', '', $task_id);
672
+
if (!empty($task_id)) {
673
+
$numeric_task_ids[] = $task_id;
674
+
}
675
+
}
676
+
677
+
if (empty($numeric_task_ids)) {
678
+
$numeric_task_ids = array(null);
673
679
}
674
-
}
675
680
676
-
if (empty($numeric_task_ids)) {
677
-
$numeric_task_ids = array(null);
681
+
$task_ids = $numeric_task_ids;
678
682
}
679
-
680
-
$task_ids = $numeric_task_ids;
681
683
682
684
$owner_phids = $request->getStrList('owners');
683
685
$author_phids = $request->getStrList('authors');