@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Move remarkup tests up one level and make them pass

Summary: Fixes T15500

Test Plan: Run `arc unit`

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15500

Differential Revision: https://we.phorge.it/D26654

Pppery 937fc1ca ba38757f

+176 -178
+1 -1
src/__phutil_library_map__.php
··· 5772 5772 'PhutilRemarkupDelRule' => 'infrastructure/markup/markuprule/PhutilRemarkupDelRule.php', 5773 5773 'PhutilRemarkupDocumentLinkRule' => 'infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php', 5774 5774 'PhutilRemarkupEngine' => 'infrastructure/markup/remarkup/PhutilRemarkupEngine.php', 5775 - 'PhutilRemarkupEngineTestCase' => 'infrastructure/markup/remarkup/__tests__/PhutilRemarkupEngineTestCase.php', 5775 + 'PhutilRemarkupEngineTestCase' => 'infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php', 5776 5776 'PhutilRemarkupEscapeRemarkupRule' => 'infrastructure/markup/markuprule/PhutilRemarkupEscapeRemarkupRule.php', 5777 5777 'PhutilRemarkupEvalRule' => 'infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php', 5778 5778 'PhutilRemarkupHeaderBlockRule' => 'infrastructure/markup/blockrule/PhutilRemarkupHeaderBlockRule.php',
+5
src/infrastructure/markup/__tests__/remarkup/link.txt
··· 1 + http://www.example.com/ 2 + ~~~~~~~~~~ 3 + <p><a href="http://www.example.com/" class="remarkup-link remarkup-link-ext" target="_blank" rel="noreferrer">http://www.example.com/</a></p> 4 + ~~~~~~~~~~ 5 + http://www.example.com/
+7
src/infrastructure/markup/__tests__/remarkup/simple-table-with-link.txt
··· 1 + | [[ http://example.com | name ]] | [x] | 2 + ~~~~~~~~~~ 3 + <div class="remarkup-table-wrap"><table class="remarkup-table"> 4 + <tr><td><a href="http://example.com" class="remarkup-link remarkup-link-ext" target="_blank" rel="noreferrer">name</a></td><td>[x]</td></tr> 5 + </table></div> 6 + ~~~~~~~~~~ 7 + | name <http://example.com> | [x] |
-2
src/infrastructure/markup/remarkup/__tests__/PhutilRemarkupEngineTestCase.php src/infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php
··· 2 2 3 3 /** 4 4 * Test cases for @{class:PhutilRemarkupEngine}. 5 - * @TODO: This unit is not always triggered when you need it. 6 - * https://we.phorge.it/T15500 7 5 */ 8 6 final class PhutilRemarkupEngineTestCase extends PhutilTestCase { 9 7
src/infrastructure/markup/remarkup/__tests__/remarkup/across-newlines.txt src/infrastructure/markup/__tests__/remarkup/across-newlines.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/backticks-whitespace.txt src/infrastructure/markup/__tests__/remarkup/backticks-whitespace.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/block-then-list.txt src/infrastructure/markup/__tests__/remarkup/block-then-list.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/code-block-guess-from-name.txt src/infrastructure/markup/__tests__/remarkup/code-block-guess-from-name.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/code-block-whitespace.txt src/infrastructure/markup/__tests__/remarkup/code-block-whitespace.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/del.txt src/infrastructure/markup/__tests__/remarkup/del.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/diff.txt src/infrastructure/markup/__tests__/remarkup/diff.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/disallowed-link.txt src/infrastructure/markup/__tests__/remarkup/disallowed-link.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/entities.txt src/infrastructure/markup/__tests__/remarkup/entities.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/header-skip.txt src/infrastructure/markup/__tests__/remarkup/header-skip.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/headers.txt src/infrastructure/markup/__tests__/remarkup/headers.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/hex-color-code.txt src/infrastructure/markup/__tests__/remarkup/hex-color-code.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/highlight.txt src/infrastructure/markup/__tests__/remarkup/highlight.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/horizonal-rule.txt src/infrastructure/markup/__tests__/remarkup/horizonal-rule.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/important.txt src/infrastructure/markup/__tests__/remarkup/important.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/interpreter-test.txt src/infrastructure/markup/__tests__/remarkup/interpreter-test.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/just-backticks.txt src/infrastructure/markup/__tests__/remarkup/just-backticks.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/leading-newline.txt src/infrastructure/markup/__tests__/remarkup/leading-newline.txt
-5
src/infrastructure/markup/remarkup/__tests__/remarkup/link.txt
··· 1 - http://www.example.com/ 2 - ~~~~~~~~~~ 3 - <p><a href="http://www.example.com/" class="remarkup-link" target="_blank" rel="noreferrer">http://www.example.com/</a></p> 4 - ~~~~~~~~~~ 5 - http://www.example.com/
src/infrastructure/markup/remarkup/__tests__/remarkup/list-alternate-style.txt src/infrastructure/markup/__tests__/remarkup/list-alternate-style.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-blow-stack.txt src/infrastructure/markup/__tests__/remarkup/list-blow-stack.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-checkboxes.txt src/infrastructure/markup/__tests__/remarkup/list-checkboxes.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-crazystairs.txt src/infrastructure/markup/__tests__/remarkup/list-crazystairs.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-first-style-wins.txt src/infrastructure/markup/__tests__/remarkup/list-first-style-wins.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-hash.txt src/infrastructure/markup/__tests__/remarkup/list-hash.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-header-last.txt src/infrastructure/markup/__tests__/remarkup/list-header-last.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-header.txt src/infrastructure/markup/__tests__/remarkup/list-header.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-mixed-styles.txt src/infrastructure/markup/__tests__/remarkup/list-mixed-styles.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-multi.txt src/infrastructure/markup/__tests__/remarkup/list-multi.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-multiline.txt src/infrastructure/markup/__tests__/remarkup/list-multiline.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-nest.txt src/infrastructure/markup/__tests__/remarkup/list-nest.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-paragraphs.txt src/infrastructure/markup/__tests__/remarkup/list-paragraphs.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-staircase.txt src/infrastructure/markup/__tests__/remarkup/list-staircase.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-star.txt src/infrastructure/markup/__tests__/remarkup/list-star.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-then-a-list.txt src/infrastructure/markup/__tests__/remarkup/list-then-a-list.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list-vs-codeblock.txt src/infrastructure/markup/__tests__/remarkup/list-vs-codeblock.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/list.txt src/infrastructure/markup/__tests__/remarkup/list.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/monospaced-in-monospaced.txt src/infrastructure/markup/__tests__/remarkup/monospaced-in-monospaced.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/monospaced-plural.txt src/infrastructure/markup/__tests__/remarkup/monospaced-plural.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/monospaced.txt src/infrastructure/markup/__tests__/remarkup/monospaced.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/newline-then-block.txt src/infrastructure/markup/__tests__/remarkup/newline-then-block.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/note-multiline.txt src/infrastructure/markup/__tests__/remarkup/note-multiline.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/note.txt src/infrastructure/markup/__tests__/remarkup/note.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/ordered-list-with-numbers.txt src/infrastructure/markup/__tests__/remarkup/ordered-list-with-numbers.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/percent-block-adjacent.txt src/infrastructure/markup/__tests__/remarkup/percent-block-adjacent.txt
+1 -1
src/infrastructure/markup/remarkup/__tests__/remarkup/percent-block-multiline.txt src/infrastructure/markup/__tests__/remarkup/percent-block-multiline.txt
··· 10 10 <br />- second 11 11 <br />- third</p> 12 12 13 - <p><a href="http://hello" class="remarkup-link" target="_blank" rel="noreferrer">world</a></p> 13 + <p><a href="http://hello" class="remarkup-link remarkup-link-ext" target="_blank" rel="noreferrer">world</a></p> 14 14 ~~~~~~~~~~ 15 15 **foo** 16 16
src/infrastructure/markup/remarkup/__tests__/remarkup/percent-block-oneline.txt src/infrastructure/markup/__tests__/remarkup/percent-block-oneline.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/percent-block-solo.txt src/infrastructure/markup/__tests__/remarkup/percent-block-solo.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/percent-block-unterminated.txt src/infrastructure/markup/__tests__/remarkup/percent-block-unterminated.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-angry.txt src/infrastructure/markup/__tests__/remarkup/quoted-angry.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-code-block.txt src/infrastructure/markup/__tests__/remarkup/quoted-code-block.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-indent-block.txt src/infrastructure/markup/__tests__/remarkup/quoted-indent-block.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-lists.txt src/infrastructure/markup/__tests__/remarkup/quoted-lists.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-paragraphs.txt src/infrastructure/markup/__tests__/remarkup/quoted-paragraphs.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-quote.txt src/infrastructure/markup/__tests__/remarkup/quoted-quote.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/quotes.txt src/infrastructure/markup/__tests__/remarkup/quotes.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/raw-escape.txt src/infrastructure/markup/__tests__/remarkup/raw-escape.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/reply-basic.txt src/infrastructure/markup/__tests__/remarkup/reply-basic.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/reply-nested.txt src/infrastructure/markup/__tests__/remarkup/reply-nested.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/simple-table-with-empty-row.txt src/infrastructure/markup/__tests__/remarkup/simple-table-with-empty-row.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/simple-table-with-leading-space.txt src/infrastructure/markup/__tests__/remarkup/simple-table-with-leading-space.txt
-7
src/infrastructure/markup/remarkup/__tests__/remarkup/simple-table-with-link.txt
··· 1 - | [[ http://example.com | name ]] | [x] | 2 - ~~~~~~~~~~ 3 - <div class="remarkup-table-wrap"><table class="remarkup-table"> 4 - <tr><td><a href="http://example.com" class="remarkup-link" target="_blank" rel="noreferrer">name</a></td><td>[x]</td></tr> 5 - </table></div> 6 - ~~~~~~~~~~ 7 - | name <http://example.com> | [x] |
src/infrastructure/markup/remarkup/__tests__/remarkup/simple-table.txt src/infrastructure/markup/__tests__/remarkup/simple-table.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/simple.txt src/infrastructure/markup/__tests__/remarkup/simple.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/table-with-direct-content.txt src/infrastructure/markup/__tests__/remarkup/table-with-direct-content.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/table-with-leading-space.txt src/infrastructure/markup/__tests__/remarkup/table-with-leading-space.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/table-with-long-header.txt src/infrastructure/markup/__tests__/remarkup/table-with-long-header.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/table.txt src/infrastructure/markup/__tests__/remarkup/table.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/tick-block-flavored.txt src/infrastructure/markup/__tests__/remarkup/tick-block-flavored.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/tick-block-multi-flavored-comment.txt src/infrastructure/markup/__tests__/remarkup/tick-block-multi-flavored-comment.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/tick-block-multi-flavored-empty.txt src/infrastructure/markup/__tests__/remarkup/tick-block-multi-flavored-empty.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/tick-block-multi-flavored.txt src/infrastructure/markup/__tests__/remarkup/tick-block-multi-flavored.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/tick-block-multi.txt src/infrastructure/markup/__tests__/remarkup/tick-block-multi.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/tick-block.txt src/infrastructure/markup/__tests__/remarkup/tick-block.txt
+2 -2
src/infrastructure/markup/remarkup/__tests__/remarkup/toc.txt src/infrastructure/markup/__tests__/remarkup/toc.txt
··· 13 13 <li><a href="#http-www-example-com">http://www.example.com</a></li> 14 14 </ul> 15 15 16 - <h2 class="remarkup-header"><a name="link-name"></a><a href="http://www.example.com/" class="remarkup-link" target="_blank" rel="noreferrer">link_name</a></h2> 16 + <h2 class="remarkup-header"><a name="link-name"></a><a href="http://www.example.com/" class="remarkup-link remarkup-link-ext" target="_blank" rel="noreferrer">link_name</a></h2> 17 17 18 18 <h3 class="remarkup-header"><a name="bold"></a><strong>bold</strong></h3> 19 19 20 - <h2 class="remarkup-header"><a name="http-www-example-com"></a><a href="http://www.example.com" class="remarkup-link" target="_blank" rel="noreferrer">http://www.example.com</a></h2> 20 + <h2 class="remarkup-header"><a name="http-www-example-com"></a><a href="http://www.example.com" class="remarkup-link remarkup-link-ext" target="_blank" rel="noreferrer">http://www.example.com</a></h2> 21 21 ~~~~~~~~~~ 22 22 [[ http://www.example.com/ | link_name ]] 23 23 =========================================
src/infrastructure/markup/remarkup/__tests__/remarkup/trailing-whitespace-codeblock.txt src/infrastructure/markup/__tests__/remarkup/trailing-whitespace-codeblock.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/underline.txt src/infrastructure/markup/__tests__/remarkup/underline.txt
src/infrastructure/markup/remarkup/__tests__/remarkup/warning.txt src/infrastructure/markup/__tests__/remarkup/warning.txt