@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove unnecessary empty checks from willFilterPage()

Summary: Fixes T3600. These checks are obsolete after D6512.

Test Plan: Syntax / static / inspection.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3600

Differential Revision: https://secure.phabricator.com/D6563

-40
-4
src/applications/differential/query/DifferentialRevisionQuery.php
··· 360 360 } 361 361 362 362 public function willFilterPage(array $revisions) { 363 - if (!$revisions) { 364 - return $revisions; 365 - } 366 - 367 363 $table = new DifferentialRevision(); 368 364 $conn_r = $table->establishConnection('r'); 369 365
-4
src/applications/diviner/query/DivinerAtomQuery.php
··· 75 75 } 76 76 77 77 protected function willFilterPage(array $atoms) { 78 - if (!$atoms) { 79 - return $atoms; 80 - } 81 - 82 78 $books = array_unique(mpull($atoms, 'getBookPHID')); 83 79 84 80 $books = id(new DivinerBookQuery())
-4
src/applications/legalpad/query/LegalpadDocumentQuery.php
··· 75 75 } 76 76 77 77 protected function willFilterPage(array $documents) { 78 - if (!$documents) { 79 - return $documents; 80 - } 81 - 82 78 if ($this->needDocumentBodies) { 83 79 $documents = $this->loadDocumentBodies($documents); 84 80 }
-4
src/applications/macro/query/PhabricatorMacroQuery.php
··· 157 157 } 158 158 159 159 protected function willFilterPage(array $macros) { 160 - if (!$macros) { 161 - return array(); 162 - } 163 - 164 160 $file_phids = mpull($macros, 'getFilePHID'); 165 161 $files = id(new PhabricatorFileQuery()) 166 162 ->setViewer($this->getViewer())
-4
src/applications/paste/query/PhabricatorPasteQuery.php
··· 85 85 } 86 86 87 87 protected function willFilterPage(array $pastes) { 88 - if (!$pastes) { 89 - return $pastes; 90 - } 91 - 92 88 if ($this->needRawContent) { 93 89 $pastes = $this->loadRawContent($pastes); 94 90 }
-4
src/applications/phortune/query/PhortuneAccountQuery.php
··· 39 39 } 40 40 41 41 protected function willFilterPage(array $accounts) { 42 - if (!$accounts) { 43 - return array(); 44 - } 45 - 46 42 $query = id(new PhabricatorEdgeQuery()) 47 43 ->withSourcePHIDs(mpull($accounts, 'getPHID')) 48 44 ->withEdgeTypes(array(PhabricatorEdgeConfig::TYPE_ACCOUNT_HAS_MEMBER));
-4
src/applications/phortune/query/PhortunePaymentMethodQuery.php
··· 47 47 } 48 48 49 49 protected function willFilterPage(array $methods) { 50 - if (!$methods) { 51 - return array(); 52 - } 53 - 54 50 $accounts = id(new PhortuneAccountQuery()) 55 51 ->setViewer($this->getViewer()) 56 52 ->withPHIDs(mpull($methods, 'getAccountPHID'))
-4
src/applications/phriction/query/PhrictionDocumentQuery.php
··· 60 60 } 61 61 62 62 protected function willFilterPage(array $documents) { 63 - if (!$documents) { 64 - return array(); 65 - } 66 - 67 63 $contents = id(new PhrictionContent())->loadAllWhere( 68 64 'id IN (%Ld)', 69 65 mpull($documents, 'getContentID'));
-4
src/applications/slowvote/query/PhabricatorSlowvoteQuery.php
··· 69 69 public function willFilterPage(array $polls) { 70 70 assert_instances_of($polls, 'PhabricatorSlowvotePoll'); 71 71 72 - if (!$polls) { 73 - return array(); 74 - } 75 - 76 72 $ids = mpull($polls, 'getID'); 77 73 $viewer = $this->getViewer(); 78 74
-4
src/applications/tokens/query/PhabricatorTokenReceiverQuery.php
··· 19 19 } 20 20 21 21 public function willFilterPage(array $phids) { 22 - if (!$phids) { 23 - return array(); 24 - } 25 - 26 22 $objects = id(new PhabricatorObjectHandleData($phids)) 27 23 ->setViewer($this->getViewer()) 28 24 ->loadObjects();