@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use PhutilProxyException to disambiguate repository pull errors
Summary: Ref T2569. When repository pulls fail, they don't necessarily list identifying information about which repository failed. Use a proxy exception to list that information.
Test Plan: {F51267}
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2569
Differential Revision: https://secure.phabricator.com/D6548
+7
-2
+7
-2
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
+7
-2
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
···
117
117
continue;
118
118
}
119
119
120
+
$callsign = $repository->getCallsign();
121
+
120
122
try {
121
-
$callsign = $repository->getCallsign();
122
123
$this->log("Updating repository '{$callsign}'.");
123
124
124
125
id(new PhabricatorRepositoryPullEngine())
···
150
151
$this->log("Failed to acquire lock.");
151
152
} catch (Exception $ex) {
152
153
$retry_after[$id] = time() + $min_sleep;
153
-
phlog($ex);
154
+
155
+
$proxy = new PhutilProxyException(
156
+
"Error while fetching changes to the '{$callsign}' repository.",
157
+
$ex);
158
+
phlog($proxy);
154
159
}
155
160
156
161
$this->stillWorking();