recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Be less strict when detecting dead daemons

Summary:
Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure".

This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again.

Test Plan:
- Faked an exception for all tasks.
- Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead).
- After patch: daemon setup error no longer triggers.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12306

Differential Revision: https://secure.phabricator.com/D17397

epriestley 939fb69a 6f50729a

+1 -1
+1 -1
src/applications/config/check/PhabricatorDaemonsSetupCheck.php
··· 10 10 11 11 $task_daemon = id(new PhabricatorDaemonLogQuery()) 12 12 ->setViewer(PhabricatorUser::getOmnipotentUser()) 13 - ->withStatus(PhabricatorDaemonLogQuery::STATUS_RUNNING) 13 + ->withStatus(PhabricatorDaemonLogQuery::STATUS_ALIVE) 14 14 ->withDaemonClasses(array('PhabricatorTaskmasterDaemon')) 15 15 ->setLimit(1) 16 16 ->execute();