@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an out-of-order access issue with inlines
Summary: Ref T13513. On `secure`, I caught an issue where inlines may be accessed directly before they're constructed. Instead, access them through the relevant accessor.
Test Plan: Will deploy.
Maniphest Tasks: T13513
Differential Revision: https://secure.phabricator.com/D21263
+21
-19
+16
-16
resources/celerity/map.php
+16
-16
resources/celerity/map.php
···
13
13
'core.pkg.js' => '845355f4',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => '42a2334f',
16
-
'differential.pkg.js' => '623b4801',
16
+
'differential.pkg.js' => 'b57da3e7',
17
17
'diffusion.pkg.css' => '42c75c37',
18
18
'diffusion.pkg.js' => 'a98c0bf7',
19
19
'maniphest.pkg.css' => '35995d6d',
···
379
379
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => 'a2ab19be',
380
380
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '1e413dc9',
381
381
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => '0116d3e8',
382
-
'rsrc/js/application/diff/DiffChangeset.js' => '68d963eb',
382
+
'rsrc/js/application/diff/DiffChangeset.js' => '0c083409',
383
383
'rsrc/js/application/diff/DiffChangesetList.js' => 'ac403c32',
384
384
'rsrc/js/application/diff/DiffInline.js' => 'b00168c1',
385
385
'rsrc/js/application/diff/DiffPathView.js' => '8207abf9',
···
774
774
'phabricator-darklog' => '3b869402',
775
775
'phabricator-darkmessage' => '26cd4b73',
776
776
'phabricator-dashboard-css' => '5a205b9d',
777
-
'phabricator-diff-changeset' => '68d963eb',
777
+
'phabricator-diff-changeset' => '0c083409',
778
778
'phabricator-diff-changeset-list' => 'ac403c32',
779
779
'phabricator-diff-inline' => 'b00168c1',
780
780
'phabricator-diff-path-view' => '8207abf9',
···
1000
1000
'javelin-dom',
1001
1001
'phabricator-draggable-list',
1002
1002
),
1003
+
'0c083409' => array(
1004
+
'javelin-dom',
1005
+
'javelin-util',
1006
+
'javelin-stratcom',
1007
+
'javelin-install',
1008
+
'javelin-workflow',
1009
+
'javelin-router',
1010
+
'javelin-behavior-device',
1011
+
'javelin-vector',
1012
+
'phabricator-diff-inline',
1013
+
'phabricator-diff-path-view',
1014
+
'phuix-button-view',
1015
+
),
1003
1016
'0cf79f45' => array(
1004
1017
'javelin-behavior',
1005
1018
'javelin-stratcom',
···
1511
1524
'6648270a' => array(
1512
1525
'javelin-install',
1513
1526
'javelin-dom',
1514
-
),
1515
-
'68d963eb' => array(
1516
-
'javelin-dom',
1517
-
'javelin-util',
1518
-
'javelin-stratcom',
1519
-
'javelin-install',
1520
-
'javelin-workflow',
1521
-
'javelin-router',
1522
-
'javelin-behavior-device',
1523
-
'javelin-vector',
1524
-
'phabricator-diff-inline',
1525
-
'phabricator-diff-path-view',
1526
-
'phuix-button-view',
1527
1527
),
1528
1528
'6a1583a8' => array(
1529
1529
'javelin-behavior',
+5
-3
webroot/rsrc/js/application/diff/DiffChangeset.js
+5
-3
webroot/rsrc/js/application/diff/DiffChangeset.js
···
795
795
},
796
796
797
797
_findInline: function(field, value) {
798
-
for (var ii = 0; ii < this._inlines.length; ii++) {
799
-
var inline = this._inlines[ii];
798
+
var inlines = this.getInlines();
799
+
800
+
for (var ii = 0; ii < inlines.length; ii++) {
801
+
var inline = inlines[ii];
800
802
801
803
var target;
802
804
switch (field) {
···
844
846
},
845
847
846
848
redrawFileTree: function() {
847
-
var inlines = this._inlines;
849
+
var inlines = this.getInlines();
848
850
var done = [];
849
851
var undone = [];
850
852
var inline;