recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field present

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:113]
```

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:120]
```

Closes T15794

Test Plan:
Define a date field in maniphest.custom-field-definitions, have more than 100 Maniphest tasks, and select some to bulk-edit them. Example config:

lang=json
{
"mycompany.deadline": {
"name": "Deadline",
"type": "date",
"caption": "Estimated deadline.",
"search": true
}
}

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15794

Differential Revision: https://we.phorge.it/D25599

Andre Klapper 93c7444d b32b84b6

+2 -2
+2 -2
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php
··· 110 110 } 111 111 112 112 $min_str = idx($value, 'min', ''); 113 - if (strlen($min_str)) { 113 + if (phutil_nonempty_string($min_str)) { 114 114 $min = PhabricatorTime::parseLocalTime($min_str, $viewer); 115 115 } else { 116 116 $min = null; 117 117 } 118 118 119 119 $max_str = idx($value, 'max', ''); 120 - if (strlen($max_str)) { 120 + if (phutil_nonempty_string($max_str)) { 121 121 $max = PhabricatorTime::parseLocalTime($max_str, $viewer); 122 122 } else { 123 123 $max = null;