@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Check for strlen instead of null for Maniphest title
Summary: Fixes T12744. Unclear why `null` doesn't work here but does for the title, but `!strlen` seems to work fine in both cases.
Test Plan: Create a new task, check mail folder, see [Created]
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12744
Differential Revision: https://secure.phabricator.com/D18002
authored by
Chad Little
and committed by
chad
93d8b33c
20e7f7d0
+4
-3
+4
-3
src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
+4
-3
src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
···
19
19
20
20
public function getActionName() {
21
21
$old = $this->getOldValue();
22
-
$new = $this->getNewValue();
23
-
if ($old === null) {
22
+
23
+
if (!strlen($old)) {
24
24
return pht('Created');
25
25
}
26
26
···
29
29
30
30
public function getTitle() {
31
31
$old = $this->getOldValue();
32
-
if ($old === null) {
32
+
33
+
if (!strlen($old)) {
33
34
return pht(
34
35
'%s created this task.',
35
36
$this->renderAuthor());