@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Support - Differential - fix rendering feed story where you removed a repository
Summary: Fixes T6176. Language here is a bit awkard but I wanted to use the verb "removed" *and* still have the object first, so I ended up adding the before details parenthetically.
Test Plan: story no longer fatal'd in my feed
Reviewers: epriestley, chad
Reviewed By: chad
Subscribers: epriestley, Korvin
Maniphest Tasks: T6176
Differential Revision: https://secure.phabricator.com/D10549
+8
-2
+8
-2
src/applications/differential/customfield/DifferentialRepositoryField.php
+8
-2
src/applications/differential/customfield/DifferentialRepositoryField.php
···
107
107
$old = $xaction->getOldValue();
108
108
$new = $xaction->getNewValue();
109
109
110
-
if ($old) {
110
+
if ($old && $new) {
111
111
return pht(
112
112
'%s updated the repository for %s from %s to %s.',
113
113
$xaction->renderHandleLink($author_phid),
114
114
$xaction->renderHandleLink($object_phid),
115
115
$xaction->renderHandleLink($old),
116
116
$xaction->renderHandleLink($new));
117
-
} else {
117
+
} else if ($new) {
118
118
return pht(
119
119
'%s set the repository for %s to %s.',
120
120
$xaction->renderHandleLink($author_phid),
121
121
$xaction->renderHandleLink($object_phid),
122
122
$xaction->renderHandleLink($new));
123
+
} else {
124
+
return pht(
125
+
'%s removed the repository for %s. (Repository was %s.)',
126
+
$xaction->renderHandleLink($author_phid),
127
+
$xaction->renderHandleLink($object_phid),
128
+
$xaction->renderHandleLink($old));
123
129
}
124
130
}
125
131